Date: Fri, 20 Sep 1996 04:20:04 -0700 (PDT) From: asami@freebsd.org (Satoshi Asami) To: freebsd-bugs Subject: Re: bin/1643: Support for NetBSD in bsd.port.mk Message-ID: <199609201120.EAA13379@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/1643; it has been noted by GNATS.
From: asami@freebsd.org (Satoshi Asami)
To: FreeBSD-gnats-submit@freefall.FreeBSD.org
Cc: Subject: Re: bin/1643: Support for NetBSD in bsd.port.mk
Date: Fri, 20 Sep 1996 04:13:29 -0700 (PDT)
* From: Jason Thorpe <thorpej@nas.nasa.gov>
Thanks for your submission, Jason. Now, my comments:
* ! # $Id: bsd.port.mk,v 1.1.1.2 1996/09/19 04:46:10 thorpej Exp $
* ! # from FreeBSD Id: bsd.port.mk,v 1.224 1996/08/25 21:07:38 wosch Exp
You should clean up your patches before sending it over you know. :)
* + # If NetBSD, we need to include bsd.own.mk to get system make
* + # configuration options.
* + .if (${OPSYS} == "NetBSD")
* + .include <bsd.own.mk>
* + .endif
* +
This doesn't belong to bsd.port.mk. I don't mind including NetBSD
support, but not crude hacks of this kind. Why does this have to be
in bsd.port.mk?
* ! # by individual Makefiles or local system make configuration.
* ! .if (${OPSYS} == "NetBSD")
* ! PORTSDIR?= ${DESTDIR}/usr/opt
* ! .else
* PORTSDIR?= ${DESTDIR}/usr/ports
* + .endif
Looks good....
* + .if (${OPSYS} == "NetBSD")
* + MD5?= /usr/bin/md5
* + .else
* MD5?= /sbin/md5
* + .endif
Ok....
* ! ${ECHO_MSG} "===> Applying ${OPSYS} patches for ${PKGNAME}" ; \
Yes....
* + # XXXthorpej -- This needs lots of work for NetBSD!
Duh.... ;)
* ! # from FreeBSD Id: bsd.port.subdir.mk,v 1.14 1996/04/09 22:54:13 wosch Exp
Please.... ;>
Satoshi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199609201120.EAA13379>