From owner-freebsd-arch@FreeBSD.ORG  Tue Apr 15 08:17:17 2003
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5F1D437B401
	for <arch@FreeBSD.ORG>; Tue, 15 Apr 2003 08:17:17 -0700 (PDT)
Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B03CA43FB1
	for <arch@FreeBSD.ORG>; Tue, 15 Apr 2003 08:17:16 -0700 (PDT)
	(envelope-from mdodd@FreeBSD.ORG)
Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223])
	by sasami.jurai.net (8.12.9/8.12.9) with ESMTP id h3FFHEEF018058;
	Tue, 15 Apr 2003 11:17:14 -0400 (EDT)
	(envelope-from mdodd@FreeBSD.ORG)
Date: Tue, 15 Apr 2003 11:17:13 -0400 (EDT)
From: "Matthew N. Dodd" <mdodd@FreeBSD.ORG>
X-X-Sender: winter@sasami.jurai.net
To: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030415.091209.108403664.imp@bsdimp.com>
Message-ID: <20030415111653.F99028@sasami.jurai.net>
References: <20030415102955.S99028@sasami.jurai.net>
	<20030415.083615.91276433.imp@bsdimp.com>
	<20030415.091209.108403664.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: arch@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Apr 2003 15:17:17 -0000

On Tue, 15 Apr 2003, M. Warner Losh wrote:
> foo |= BIT;
> if ((foo & BIT) == 0)
>    whine-and-fail;

Indeed.

> is that what you are saying?
>
> : This would keep drivers from having to check and see if PCIM_CMD_PORTEN or
> : PCIM_CMD_MEMEN is set.
>
> Yes.
>
> : This requires changing the definition of the 'enable_io' method.
> :
> : Since we're here we should change 'disable_io' and
> : '{enable,disable}_busmaster' as well.
>
> If we're going to do this, then we need to do it soon.

I'm working on patches.

-- 
| Matthew N. Dodd  | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD  |
| winter@jurai.net |       2 x '84 Volvo 245DL        | ix86,sparc,pmax |
| http://www.jurai.net/~winter |  For Great Justice!  | ISO8802.5 4ever |