From owner-svn-src-all@freebsd.org Mon Jun 24 02:59:24 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E25C15BCDB6; Mon, 24 Jun 2019 02:59:24 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vtr.rulingia.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7DD61828EC; Mon, 24 Jun 2019 02:59:23 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp59-167-167-3.static.internode.on.net [59.167.167.3]) by vtr.rulingia.com (8.15.2/8.15.2) with ESMTPS id x5O2xDEX088048 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Jun 2019 12:59:19 +1000 (AEST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.15.2/8.15.2) with ESMTPS id x5O2x8iZ087966 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 24 Jun 2019 12:59:08 +1000 (AEST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.15.2/8.15.2/Submit) id x5O2x8t8087965; Mon, 24 Jun 2019 12:59:08 +1000 (AEST) (envelope-from peter) Date: Mon, 24 Jun 2019 12:59:08 +1000 From: Peter Jeremy To: Xin LI Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349151 - in head: lib/libufs stand/libsa sys/conf sys/dev/iscsi sys/dev/iscsi_initiator sys/dev/liquidio sys/dev/usb/net sys/fs/ext2fs sys/fs/nandfs sys/geom/part sys/geom/raid sys/ker... Message-ID: <20190624025908.GA87860@server.rulingia.com> References: <201906171949.x5HJn9Ed091108@repo.freebsd.org> <20190622071703.GA71146@server.rulingia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <20190622071703.GA71146@server.rulingia.com> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.12.0 (2019-05-25) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jun 2019 02:59:24 -0000 --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-Jun-22 17:17:03 +1000, Peter Jeremy wro= te: >On 2019-Jun-17 19:49:09 +0000, Xin LI wrote: >>Author: delphij >>Date: Mon Jun 17 19:49:08 2019 >>New Revision: 349151 >>URL: https://svnweb.freebsd.org/changeset/base/349151 >> >>Log: >> Separate kernel crc32() implementation to its own header (gsb_crc32.h) = and >> rename the source to gsb_crc32.c. > >I'm not sure how but this breaks my Rock64. r349150 boots without problem >but r349151 panics during the probe: >... And the problem went away somewhere between r349269 and r349288. Since the= re's nothing obvious there either, I presume this is something more subtle like a race condition that has been provoked by the code changes. --=20 Peter Jeremy --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAl0QPGtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzQPyhAAmU38utmmqCxwiN+yNYib5hOThLLMIoJTe14iJamxa0Ubrcw5c1FSxZlG 1XgOxR40vNIx7QNiGIZGd0L0rdIf7znmNRj/idqX2o/ZnKk9d6YHbNkr4SQghdu2 YGE1cSNIH6yVhpEAUw9AdGAgAfZmMAj212igWilyO+UdXLzwT4knyBF65+Ud1cuT yt6rHGfRv/i7EgObLAbJpOxbzMmbq3il/GLC/Egp7j+Ujkr5WUj69hDtljuOn4oh FFNriIAUlSZDrWyp5i7Tepl2Qv6RvlSaZBxq8xW8whWVMU41yN2MO0QMmXtceOMQ Ie45W5I8l1+MXQ+BzzLYoVyw28bJVFAIxhCLJpdaHNtsG+L8/cFiOpp6iQ2Dr9jr h9eiBHcbdz6d/aFoSez5TTLzNLEXy0eJ8XQ56x6nWpKSSWGk7gcvemaalchtDUZR c4iFsmVZRajZIFyarWuUaf70cKjP4Fl6yHxrD+Q8j1vbzgozRRy8gDaHlI3ZvzkK GesE538jGf4Tzl9AIIfG/mjREWAdw7iJIUynNLRwZBchXL7majFr6GSLdS331aOq Iar59CpwpXj3jVXjuURWmiQ8RXrvBF1ImGBZkPFIpa3CqzRs1MAioWgVn8L443nm hnFvy2hKpUnGxbdiMN9zvc5xeGbrN6Hg2MuadC3EZP9WW01FOZ0= =rkFC -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--