From owner-freebsd-current@freebsd.org Thu May 13 18:52:09 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EDD5262B1A1 for ; Thu, 13 May 2021 18:52:09 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fh13s63kBz3mG8; Thu, 13 May 2021 18:52:09 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-ed1-x535.google.com with SMTP id l7so32155175edb.1; Thu, 13 May 2021 11:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=VC83t4Y/ozwmPhs+pGwbCqtFFVN7EXHIC//ZMfmZK0Q=; b=dbpGfweRfsjruBMrfcVbdXXeOq1UFuARYRIfcfpLSrcZUN0dm01dDWMrVQk+dQI0Ag +MA0fy1mQeoGm+pT5BGg/c8mRa0YVWCYwOZ1zOTh1L2swsaGslM+aAQJHP+e1DWZrtLn WaDiTb+nl2mDlpFICBtcCTWnJoqETtBAqQtId9uAyQAyN2tXaJyxUGLhRKjxNc383iXG FCiH9ns8IqJD3T8rmwwrNzDg4OkbDDXoGeiaRS+5tM4BsRbe20fshL7MlBGPKiEn8UHj cExY73oYyPIAFhXbkbuIc50hjlAZw325A91J/TaaCAnLeJiiL668wew5ytPVoy2M3559 weFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=VC83t4Y/ozwmPhs+pGwbCqtFFVN7EXHIC//ZMfmZK0Q=; b=S342IO0Kxfpd95i4YRy5qNkxTHawz7aZyVMaGaarn7rXy9JpZa2a+QGPsFf7FYLmrT Jf2+odXmhtaEGm+Xeq55o6pCTPrA/6JT8ejOrSoTQ3Tjr+RizQJ/+9BAZcDtidwAz576 1raitph6jd7hCoNge72i/WTq1eHDWADX2IEHpkfdsoPuY4BnIcDIGmEB5/Qzj/uSWnmM 7/s9SX+dzWj7Iwck2P62smUgDdg8s1J0IVE99K046f6EPI804QC6X8apLBA6+pr7DFVe T6yTaP0yb71zmykdRtBjmrfFjcnh9yzSmqF57T8dxw38BpCGOfNojXi1HbmXU5TdkBdE RKBQ== X-Gm-Message-State: AOAM531tJaFwN1LCs9it7iadfxNqvgNIyMoAEcxaFuVKiOuvj+J9GWUV ZDNLg0fURgq4+6hJC34YxugoDaqakPM= X-Google-Smtp-Source: ABdhPJysIP5NbBucFjjhrb2l5BqQyX/8KQhu+0vn4/ztcKjo1oBGUYSPrj6ksb0IgdO/l8PUD84Srw== X-Received: by 2002:a05:6402:34c5:: with SMTP id w5mr52881344edc.237.1620931928415; Thu, 13 May 2021 11:52:08 -0700 (PDT) Received: from ernst.home (pd9e23d76.dip0.t-ipconnect.de. [217.226.61.118]) by smtp.gmail.com with ESMTPSA id u8sm2760535edo.71.2021.05.13.11.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 11:52:07 -0700 (PDT) Date: Thu, 13 May 2021 20:52:05 +0200 From: Gary Jennejohn To: Lev Serebryakov Cc: Henri Hennebert , Marc Veldman , freebsd-current@freebsd.org Subject: Re: CURRENT crashes at early boot on Lenovo T540p: rtsx to blame - 13.0-RELEASE crashes same way! Message-ID: <20210513185205.17816dc5@ernst.home> In-Reply-To: References: <9f0abf48-ed13-bff3-5687-fca0d57195d8@restart.be> <8d4e076b-9ecd-aef2-0ee8-73519bb9d939@FreeBSD.org> <8d2be5f2-4144-082e-4237-0dac0c4b37e6@restart.be> <6798878a-c499-d78d-e96d-d744513cb80d@restart.be> <1de588e2-20cb-3206-3aea-f3f88f577675@restart.be> <67f0874a-6a05-67f1-3f2b-c4b3dc67fa11@FreeBSD.org> <83b823bf-c6c2-2f6a-b5dd-2e91b4d1931e@restart.be> <2c208bbc-5adc-2327-4717-a5e7c8d64b4b@FreeBSD.org> <9a15daa7-2b17-e257-d4d1-850c632a9db8@restart.be> <417a97b9-2c40-310c-c445-b193c493b880@FreeBSD.org> <7eb763ce-0bbf-9baf-2ede-968ee25cff2e@restart.be> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Fh13s63kBz3mG8 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2021 18:52:10 -0000 On Thu, 13 May 2021 20:55:20 +0300 Lev Serebryakov wrote: > On 13.05.2021 18:56, Henri Hennebert wrote: > > > So if I understand correctly, your problem is solved. > Stupid me. I didn't check card insertion/removal after boot. > > Card REMOVAL when boot was WITH CARD: > Instant panic: > > rtsx0: Interrupt card inserted/removed > rtsx0: Card absent > panic: mutex Giant not owned at /usr/src/sys/kern/subr_bus.c:3045 > cpuid = 3 > time = 1620928154 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c6a989c0 > vpanic() at vpanic+0x181/frame 0xfffffe00c6a98a10 > panic() at panic+0x43/frame 0xfffffe00c6a98a70 > __mtx_assert() at __mtx_assert+0xb0/frame 0xfffffe00c6a98a80 > device_detach() at device_detach+0x2e/frame 0xfffffe00c6a98ac0 > device_delete_child() at device_delete_child+0x15/frame 0xfffffe00c6a98ae0 > rtsx_card_task() at rtsx_card_task+0xfa/frame 0xfffffe00c6a98b00 > taskqueue_run_locked() at taskqueue_run_locked+0xaa/frame 0xfffffe00c6a98b80 > taskqueue_thread_loop() at taskqueue_thread_loop+0x94/frame 0xfffffe00c6a98bb0 > fork_exit() at fork_exit+0x80/frame 0xfffffe00c6a98bf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00c6a98bf0 > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > KDB: enter: panic > > Card INSERTION when boot was WITHOUT CARD: > Instant panic: > > rtsx0: Interrupt card inserted/removed > rtsx0: Card present > panic: mutex Giant not owned at /usr/src/sys/kern/subr_bus.c:2944 > cpuid = 1 > time = 1620928312 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c6a98a10 > vpanic() at vpanic+0x181/frame 0xfffffe00c6a98a60 > panic() at panic+0x43/frame 0xfffffe00c6a98ac0 > __mtx_assert() at __mtx_assert+0xb0/frame 0xfffffe00c6a98ad0 > device_probe_and_attach() at device_probe_and_attach+0x2a/frame 0xfffffe00c6a98b00 > taskqueue_run_locked() at taskqueue_run_locked+0xaa/frame 0xfffffe00c6a98b80 > taskqueue_thread_loop() at taskqueue_thread_loop+0x94/frame 0xfffffe00c6a98bb0 > fork_exit() at fork_exit+0x80/frame 0xfffffe00c6a98bf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00c6a98bf0 > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > KDB: enter: panic > > Both panics are "debuggable", as keyboard is working in ddb and crash dump could be created. And I'm not sure, that GIANT in 2021 is good thing. > Yeah, I was wondering about that myself when looked at the code today. The driver was originally developed when current was what is now 12 or 13, I think. Might be worth looking at dwmmc.c (where I got the card insertion/removal code) to see whether there are any recent changes there. -- Gary Jennejohn