From owner-svn-src-head@freebsd.org Sat Dec 1 01:54:11 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5475811576F9 for ; Sat, 1 Dec 2018 01:54:11 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5F0E981B8F for ; Sat, 1 Dec 2018 01:54:10 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-ed1-x52c.google.com with SMTP id x30so6342927edx.2 for ; Fri, 30 Nov 2018 17:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1rKcat5mF3zk/GLM4zJJ2Xv+0Vn9PUsYs/b1UAzKoZQ=; b=K7D8MWvTcQDOwc8w/pbo8CmF/DkMrHhhEgSfQN63bT0OseknkR5koqbVuGebZhI/0X zIlhS91eseOF73UA4vNcG+duyPDFwscm0JJvOXAwGoDwO4Jjo3+b3G09zMDD8U14cKIy sIUCoCkeuElQ0oaCNiuWKFyy7iMmx6ZjMLYXd1CGsiajtXV0U8IrPnP4BQ84kOS0dWlW Miwes9XHRaIwtCpzcMsNoYv3jLaL/7owHa0VmZOpJcKJxDYr3IBErm0dYE4NITF6agIn smW8XcV+9bDOUkOcT9r928oJpIh6fLxIKK1RtPIb3UatDb+hhTCJLZHKFzj5krXO9iC2 0asw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1rKcat5mF3zk/GLM4zJJ2Xv+0Vn9PUsYs/b1UAzKoZQ=; b=O/tskTZLM3leiHZAIeZuUSdRyl7YXhjbq8PO6T0NMe6yNabpT9tH0xEr7sJVrhnUme shVVOphUW9rCvnPnnC7rwuroJ3TDseXgOHGeEpEBZZElPtPEJK4ljWm7upOtafl4e1jd P5C8gYXuTU1tKuxJLJF8NH6cZZg7uKVj1v7Yl5Zhm2qyf13T3RTnnZYLIY1KDfUwbDXQ y1pN6esGLao+YNnIlesLfrR6jJqVUYCYrQTyvt33aWdjd18YzjcElwF8J58wFvudgAcp UtB5zFKGETM6cMsyfni49SwPbm9shtr/uTovY2dyILRi2/yqfOMsnTirF3LAH8SePHmm IqMA== X-Gm-Message-State: AA+aEWZo8WJNclReFL9FEI3+V7izefJ2I4MlFu8OInYQgX5aPLpiJ/+e 3p7Cp4QcNiRbrRBeUk6xwGkkaQ== X-Google-Smtp-Source: AFSGD/VkaPRnHQteTEeRhh2BZ/r143Tb59HQvvp2AOvrZmDy8QzoKDtUN8YI9NVBTZwC1Rzx6FixVg== X-Received: by 2002:a50:c2d9:: with SMTP id u25mr7178815edf.280.1543629249102; Fri, 30 Nov 2018 17:54:09 -0800 (PST) Received: from [10.44.128.75] ([161.12.40.153]) by smtp.gmail.com with ESMTPSA id b11-v6sm1030017eje.38.2018.11.30.17.54.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Nov 2018 17:54:07 -0800 (PST) Subject: Re: svn: head/usr.bin: . trim To: Eugene Grosbein Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Cy Schubert References: <20181130011713.42B641D27@spqr.komquats.com> <0e233c0c-6c80-4618-9618-48162362a849@multiplay.co.uk> <20181130084955.o4loxtuswdsvzksy@ivaldir.net> <20181130105714.GA84052@FreeBSD.org> <15e4f063-d081-9c38-be3e-44bc622cc50e@freebsd.org> <20181130113422.GA14353@FreeBSD.org> <20181130115515.GA28531@FreeBSD.org> <20181130125645.GA97463@FreeBSD.org> <2ef3034e-6c4c-4fb7-3c7d-7cb41e4faac5@grosbein.net> <864fc11c-6554-f8de-5a58-dfee09a23803@multiplay.co.uk> <51e0273e-2259-28c9-1872-c3c971e4ece0@grosbein.net> From: Steven Hartland Message-ID: <3c0dae49-84ac-a3ef-32c7-f796e3eec16c@multiplay.co.uk> Date: Sat, 1 Dec 2018 01:54:07 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <51e0273e-2259-28c9-1872-c3c971e4ece0@grosbein.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 5F0E981B8F X-Spamd-Result: default: False [-5.71 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[multiplay-co-uk.20150623.gappssmtp.com]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[multiplay.co.uk]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: ASPMX.L.GOOGLE.COM]; DKIM_TRACE(0.00)[multiplay-co-uk.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[c.2.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.991,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.21)[ip: (-8.13), ipnet: 2a00:1450::/32(-1.50), asn: 15169(-1.34), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2018 01:54:11 -0000 On 30/11/2018 22:09, Eugene Grosbein wrote: > 01.12.2018 4:29, Steven Hartland wrote: > >> On 30/11/2018 21:16, Eugene Grosbein wrote: >>> 30.11.2018 21:23, Warner Losh wrote: >>> >>>> So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place for it. >>> Why can't we have two implementations? Diversity is good thing. >>> >>> I can imagine erasing a partition with ZFS Cache or ZIL inside and >>> "trim /dev/da0p2 /dev/da0p3" looks much better :-) >> ZFS already does that no need for a separate tool > Think of media taken out of (possibly already dead) ZFS-based to UFS-only system. > > By the way, how exactly do you trim previously ZIL partition withing working ZFS-based system? > You could use camcontrol which can perform a secure erase on the device, but that's obviously device wide not a specific partition. What I was referring to is ZFS performs a delete of blocks when it initializes a volume, so there's usually no need to perform a manual step there. For reference this behavior can be disabled by setting vfs.zfs.vdev.trim_on_init=0     Regards     Steve