From owner-svn-ports-head@FreeBSD.ORG  Wed Jan 22 11:26:42 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 74C2D8D4; Wed, 22 Jan 2014 11:26:42 +0000 (UTC)
Date: Wed, 22 Jan 2014 11:26:42 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Akinori MUSHA <knu@FreeBSD.org>
Subject: Re: svn commit: r340703 - in head/databases/mysql-q4m: . files
Message-ID: <20140122112642.GA53001@FreeBSD.org>
References: <201401221103.s0MB3j3r098232@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201401221103.s0MB3j3r098232@svn.freebsd.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2014 11:26:42 -0000

On Wed, Jan 22, 2014 at 11:03:45AM +0000, Akinori MUSHA wrote:
> New Revision: 340703
> URL: http://svnweb.freebsd.org/changeset/ports/340703
> 
> +USE_PERL5=	yes
>  USE_GMAKE=	yes

Hmm, why not employ USES for gmake and perl5?

> -CPPFLAGS+=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include
> +CPPFLAGS+=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include -DDBUG_OFF

PTHREAD_CFLAGS is empty for a long time; you could've simply omitted it
completely here.

> -	cd ${WRKSRC}; ${PERL} run_tests.pl
> +	cd ${WRKSRC}; ./run_tests.pl

I'm not sure if this change actually makes things better: it now depends
on correct shebang, and +x permission on the script.  What was wrong with
invoking the script through ${PERL}?

./danfe