From owner-svn-src-user@FreeBSD.ORG Mon Feb 18 16:19:26 2013 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id DCC068FF; Mon, 18 Feb 2013 16:19:26 +0000 (UTC) (envelope-from crees@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id BB6A97CE; Mon, 18 Feb 2013 16:19:26 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r1IGJQkj029024; Mon, 18 Feb 2013 16:19:26 GMT (envelope-from crees@svn.freebsd.org) Received: (from crees@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id r1IGJQ9S029023; Mon, 18 Feb 2013 16:19:26 GMT (envelope-from crees@svn.freebsd.org) Message-Id: <201302181619.r1IGJQ9S029023@svn.freebsd.org> From: Chris Rees Date: Mon, 18 Feb 2013 16:19:26 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r246943 - user/crees/rclint X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2013 16:19:26 -0000 Author: crees (ports committer) Date: Mon Feb 18 16:19:26 2013 New Revision: 246943 URL: http://svnweb.freebsd.org/changeset/base/246943 Log: Fix style fix (tmp.value != False should be tmp.value) Pointyhat to: eadler Fix pointless quoting for real this time (used to detect the quotes at the beginning and end of the value) Noticed by: bdrewery Modified: user/crees/rclint/rclint.py Modified: user/crees/rclint/rclint.py ============================================================================== --- user/crees/rclint/rclint.py Mon Feb 18 16:03:42 2013 (r246942) +++ user/crees/rclint/rclint.py Mon Feb 18 16:19:26 2013 (r246943) @@ -28,7 +28,7 @@ __version__ = '$FreeBSD$' MAJOR = 0 MINOR = 0 -MICRO = 4 +MICRO = 5 DATADIR = '.' @@ -112,7 +112,7 @@ class Statement: def pointless_quoted(self): if not self.quoted(): return False - for char in self.value: + for char in self.value[1:-1]: if char in ' \t|&;<>()$`\\\"\'': return False return True @@ -298,7 +298,7 @@ def do_rclint(filename): for num in range(0, len(lines)): for obj in list(lineobj.keys()): tmp = eval(obj)(lines, num) - if not tmp.value: + if tmp.value: lineobj[obj].append(tmp) break