From nobody Mon Jun 22 13:37:01 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gkTl22cvkz6hCRc for ; Mon, 22 Jun 2026 13:37:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gkTl174jCz3wBL for ; Mon, 22 Jun 2026 13:37:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782135422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BUDxw5H6YwY4NVB/9NbHXofu4U1TSPgbqKM/AVklLVg=; b=dEk7XpOQcQXHrIfE00CmlH0I0H5m6s89O/X3Hs3QYnIqZkZ9nxmmjYtD2CklOxYKTkQ7Xd 3p7hg/CdLzx6VU80+slMdmr1dC3UjFCXpl25eZzM50nO5wk5mYFUjIqY2tGot+0PC9gmSa rQCbM7dpip/bHnGKWZIEWPksQFx7qitAB+25PtzYQ+Ggg02cE+dY3A4XGZyW+iE4MeUGe7 oqosaqDNuTs+HNQiNf5aQbBMF/ab0edml/O5+Jy/QRwUbKsmm3/7l3KW8cL1zZpgt9CZYM EuouLixJvy9aJh2d8jzFEmqN6fx8mrUsQg6NtZPJRebClKAgt+Mj0MEfYwvrmQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782135422; a=rsa-sha256; cv=none; b=UuRPD0o/HUy39Ym35bIqQOzQl9QBakKyTgwFy5y55JOdPRRmvzLBCbXW7gUvxw2YEVbuSs Wm7YaJjhAAIHB/fwZGTejWBQOZ/e6dFAzKRwxRBUq9Y/LAYIbYb9SHfxBrkXwCs0CKUTMe ZKjOGW6J018GbBAkCvJWpvW9c7L8Lw5LD1a04EOHOwg5D46AF25f4446HXJOVR4LBr2RLk L4TAki8G3CcJMH4B9hs/I7N1NHSSmxdkCUM8GnuzrhiboFtcFvb/5vsS/pdKzA5cdGb8OH KQV2Jc2mvjrPbGqjjsCqfpe9SifLvZgfMno7BE45AR0PqAE4r1j5e8xVqMmn0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782135422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BUDxw5H6YwY4NVB/9NbHXofu4U1TSPgbqKM/AVklLVg=; b=BrIyPGndFyMBwkAfwQdzRiHNaR1YvX7GrnPHOGKrAD2A4zcyD2gaOF5ejd07TbOAeiOYMB /B61fN10hy1sRpezoNqnOQaCq37VcF1Isxw9Mavog8JhTLvqBaBoIWrFRm9uByg929Fo0K APTfHUufIFgvPgib5GVdGQEgzxvLSYNWNSXAqiZkVyFXisRgrmHaRksirFnJD/S1YV6II2 HbNZY/QiZYoRTn/Gcivj4HjnEvlgDQpQfUjawZsotnh0pWV0Hw6rUdpjt4Aa12s2Cm9oy9 oeuher6BIt0ebgXHLXYMpUydXtfEPP0t0JHWcEvqfw/r3Bxl5qOCaSN5lKQLQA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gkTl15yQJzqfP for ; Mon, 22 Jun 2026 13:37:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bf71 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 22 Jun 2026 13:37:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: ShengYi Hung Subject: git: 964823a18e11 - main - libusb: implement libusb_get_max_alt_packet_size List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: aokblast X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 964823a18e116e86c05e1d6a6fd80b1bb3274e57 Auto-Submitted: auto-generated Date: Mon, 22 Jun 2026 13:37:01 +0000 Message-Id: <6a393a7d.3bf71.4cfa98fe@gitrepo.freebsd.org> The branch main has been updated by aokblast: URL: https://cgit.FreeBSD.org/src/commit/?id=964823a18e116e86c05e1d6a6fd80b1bb3274e57 commit 964823a18e116e86c05e1d6a6fd80b1bb3274e57 Author: ShengYi Hung AuthorDate: 2025-07-09 10:49:24 +0000 Commit: ShengYi Hung CommitDate: 2026-06-22 13:36:47 +0000 libusb: implement libusb_get_max_alt_packet_size The libusb has a function to calculate the size from given interface, alt_setting, endpoint. Implementing it by refactoring the calculating function for libusb_get_max_iso_packet_size. Reviewed by: adrian Sponsored By: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D51225 --- lib/libusb/libusb.3 | 6 ++ lib/libusb/libusb.h | 4 +- lib/libusb/libusb10.c | 161 +++++++++++++++++++++++++++++++++++++++++--------- 3 files changed, 141 insertions(+), 30 deletions(-) diff --git a/lib/libusb/libusb.3 b/lib/libusb/libusb.3 index 7b977103eb59..d801f4c8161a 100644 --- a/lib/libusb/libusb.3 +++ b/lib/libusb/libusb.3 @@ -224,6 +224,12 @@ Returns the packet size multiplied by the packet multiplier on success, LIBUSB_ERROR_NOT_FOUND if the endpoint does not exist and LIBUSB_ERROR_OTHERS on other failure. .Pp +.Ft int +.Fn libusb_get_max_alt_packet_size "libusb_device *dev" "int interface_number" "int alternate_setting" "unsigned char endpoint" +Returns the maximum packet size which can be sent/received on this endpoint, +LIBUSB_ERROR_NOT_FOUND if the endpoint does not exist, or +LIBUSB_ERROR_OTHER on other failure. +.Pp .Ft libusb_device * .Fn libusb_ref_device "libusb_device *dev" Increment the reference counter of the device diff --git a/lib/libusb/libusb.h b/lib/libusb/libusb.h index 00255291ebd5..b6853879412c 100644 --- a/lib/libusb/libusb.h +++ b/lib/libusb/libusb.h @@ -548,7 +548,9 @@ uint8_t libusb_get_device_address(libusb_device * dev); enum libusb_speed libusb_get_device_speed(libusb_device * dev); int libusb_clear_halt(libusb_device_handle *devh, uint8_t endpoint); int libusb_get_max_packet_size(libusb_device * dev, uint8_t endpoint); -int libusb_get_max_iso_packet_size(libusb_device * dev, uint8_t endpoint); +int libusb_get_max_iso_packet_size(libusb_device *dev, uint8_t endpoint); +int libusb_get_max_alt_packet_size(libusb_device *dev, int interface_number, + int alternate_setting, unsigned char endpoint); libusb_device *libusb_ref_device(libusb_device * dev); void libusb_unref_device(libusb_device * dev); int libusb_wrap_sys_device(libusb_context *ctx, intptr_t sys_dev, libusb_device_handle **dev_handle); diff --git a/lib/libusb/libusb10.c b/lib/libusb/libusb10.c index c00d8ec8be8b..ab92c219409a 100644 --- a/lib/libusb/libusb10.c +++ b/lib/libusb/libusb10.c @@ -536,26 +536,17 @@ libusb_get_device_speed(libusb_device *dev) return (LIBUSB_SPEED_UNKNOWN); } -int -libusb_get_max_packet_size(libusb_device *dev, uint8_t endpoint) +static const libusb_endpoint_descriptor * +libusb_get_endpoint_from_config(libusb_config_descriptor *pdconf, + uint8_t endpoint) { - struct libusb_config_descriptor *pdconf; struct libusb_interface *pinf; struct libusb_interface_descriptor *pdinf; - struct libusb_endpoint_descriptor *pdend; + const struct libusb_endpoint_descriptor *pdend; int i; int j; int k; - int ret; - - if (dev == NULL) - return (LIBUSB_ERROR_NO_DEVICE); - ret = libusb_get_active_config_descriptor(dev, &pdconf); - if (ret < 0) - return (ret); - - ret = LIBUSB_ERROR_NOT_FOUND; for (i = 0; i < pdconf->bNumInterfaces; i++) { pinf = &pdconf->interface[i]; for (j = 0; j < pinf->num_altsetting; j++) { @@ -563,39 +554,151 @@ libusb_get_max_packet_size(libusb_device *dev, uint8_t endpoint) for (k = 0; k < pdinf->bNumEndpoints; k++) { pdend = &pdinf->endpoint[k]; if (pdend->bEndpointAddress == endpoint) { - ret = pdend->wMaxPacketSize; - goto out; + return (pdend); } } } } -out: + return (NULL); +} + +int +libusb_get_max_packet_size(libusb_device *dev, uint8_t endpoint) +{ + struct libusb_config_descriptor *pdconf; + const struct libusb_endpoint_descriptor *pdend; + int ret; + + if (dev == NULL) + return (LIBUSB_ERROR_OTHER); + + ret = libusb_get_active_config_descriptor(dev, &pdconf); + if (ret < 0) + return (ret); + + ret = LIBUSB_ERROR_NOT_FOUND; + if ((pdend = libusb_get_endpoint_from_config(pdconf, endpoint)) != NULL) + ret = pdend->wMaxPacketSize; + libusb_free_config_descriptor(pdconf); return (ret); } +static int +libusb_calculate_ep_size(libusb_device *dev, + const libusb_endpoint_descriptor *ep) +{ + struct libusb_ss_endpoint_companion_descriptor *ss_ep; + int multiplier; + int speed; + int ret = LIBUSB_ERROR_NOT_SUPPORTED; + enum libusb_endpoint_transfer_type type; + + speed = libusb_get_device_speed(dev); + if (speed >= LIBUSB_SPEED_SUPER) { + ret = libusb_get_ss_endpoint_companion_descriptor(dev->ctx, ep, + &ss_ep); + if (ret == LIBUSB_SUCCESS) { + ret = ss_ep->wBytesPerInterval; + libusb_free_ss_endpoint_companion_descriptor(ss_ep); + } + } + + /* + * reference: + * https://www.keil.com/pack/doc/mw/usb/html/_u_s_b__endpoint__descriptor.html + */ + if (ret < 0) { + ret = ep->wMaxPacketSize; + switch (speed) { + case LIBUSB_SPEED_LOW: + case LIBUSB_SPEED_FULL: + break; + default: + type = ep->bmAttributes & 0x3; + if (type == LIBUSB_ENDPOINT_TRANSFER_TYPE_ISOCHRONOUS || + type == LIBUSB_ENDPOINT_TRANSFER_TYPE_INTERRUPT) { + multiplier = (1 + ((ret >> 11) & 3)); + if (multiplier > 3) + multiplier = 3; + ret = (ret & 0x7FF) * multiplier; + } + break; + } + } + + return (ret); +} + int libusb_get_max_iso_packet_size(libusb_device *dev, uint8_t endpoint) { - int multiplier; + struct libusb_config_descriptor *pdconf; + const struct libusb_endpoint_descriptor *pdend; int ret; - ret = libusb_get_max_packet_size(dev, endpoint); + if (dev == NULL) + return (LIBUSB_ERROR_OTHER); - switch (libusb20_dev_get_speed(dev->os_priv)) { - case LIBUSB20_SPEED_LOW: - case LIBUSB20_SPEED_FULL: - break; - default: - if (ret > -1) { - multiplier = (1 + ((ret >> 11) & 3)); - if (multiplier > 3) - multiplier = 3; - ret = (ret & 0x7FF) * multiplier; + ret = libusb_get_active_config_descriptor(dev, &pdconf); + if (ret < 0) + return (LIBUSB_ERROR_OTHER); + + pdend = libusb_get_endpoint_from_config(pdconf, endpoint); + if (pdend == NULL) { + libusb_free_config_descriptor(pdconf); + return (LIBUSB_ERROR_NOT_FOUND); + } + + ret = libusb_calculate_ep_size(dev, pdend); + libusb_free_config_descriptor(pdconf); + return (ret); +} + +int +libusb_get_max_alt_packet_size(libusb_device *dev, int interface_number, + int alternate_setting, unsigned char endpoint) +{ + struct libusb_config_descriptor *pdconf; + struct libusb_interface *pinf; + struct libusb_interface_descriptor *pdinf; + const struct libusb_endpoint_descriptor *pdend = NULL; + const struct libusb_endpoint_descriptor *pdend_tmp; + int ret, i; + + if (dev == NULL) + return (LIBUSB_ERROR_OTHER); + + ret = libusb_get_active_config_descriptor(dev, &pdconf); + if (ret < 0) + return (LIBUSB_ERROR_OTHER); + + if (pdconf->bNumInterfaces <= interface_number) { + libusb_free_config_descriptor(pdconf); + return (LIBUSB_ERROR_NOT_FOUND); + } + pinf = &pdconf->interface[interface_number]; + + if (pinf->num_altsetting <= alternate_setting) { + libusb_free_config_descriptor(pdconf); + return (LIBUSB_ERROR_NOT_FOUND); + } + pdinf = &pinf->altsetting[alternate_setting]; + + for (i = 0; i < pdinf->bNumEndpoints; ++i) { + pdend_tmp = &pdinf->endpoint[i]; + if (pdend_tmp->bEndpointAddress == endpoint) { + pdend = pdend_tmp; + break; } - break; } + if (pdend != NULL) + ret = libusb_calculate_ep_size(dev, pdend); + else + ret = LIBUSB_ERROR_NOT_FOUND; + libusb_free_config_descriptor(pdconf); + return (ret); }