Date: Tue, 5 Jul 2016 11:20:06 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r299496 - head/contrib/atf/atf-c/detail Message-ID: <CAOfEmZjs=0n3wS4OmzSmm48ffap%2BJyyGL5Rjtmw4HriTPegGBQ@mail.gmail.com> In-Reply-To: <201605112339.u4BNdehd062987@repo.freebsd.org> References: <201605112339.u4BNdehd062987@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Isn't need to have approve from re@ to commit now? As we are closer to have 11-RELEASE. Best, 2016-05-12 7:39 GMT+08:00 Conrad E. Meyer <cem@freebsd.org>: > Author: cem > Date: Wed May 11 23:39:39 2016 > New Revision: 299496 > URL: https://svnweb.freebsd.org/changeset/base/299496 > > Log: > atf map: Fix double-free in low memory error path > > If atf_list_append(, X, ) fails, X is freed. Don't free it again. > > If anyone wants to walk this patch upstream, be my guest. I literally > cannot > upstream it myself due to Google's stupid CLA. > > Reported by: Coverity > CID: 979936 > Sponsored by: EMC / Isilon Storage Division > > Modified: > head/contrib/atf/atf-c/detail/map.c > > Modified: head/contrib/atf/atf-c/detail/map.c > > ============================================================================== > --- head/contrib/atf/atf-c/detail/map.c Wed May 11 23:25:59 2016 > (r299495) > +++ head/contrib/atf/atf-c/detail/map.c Wed May 11 23:39:39 2016 > (r299496) > @@ -360,7 +360,6 @@ atf_map_insert(atf_map_t *m, const char > if (atf_is_error(err)) { > if (managed) > free(value); > - free(me); > } > } > } else { > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZjs=0n3wS4OmzSmm48ffap%2BJyyGL5Rjtmw4HriTPegGBQ>