Date: Wed, 12 Oct 2016 17:35:34 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Kyle Evans <kevans91@ksu.edu>, ports-list freebsd <freebsd-ports@freebsd.org> Subject: Re: qa.sh stripped warning Message-ID: <a7c84b19-0b61-0584-0bad-ef0ecfc2864c@FreeBSD.org> In-Reply-To: <CACNAnaH=bfFDy0rgO2_VPtx3U6k6uwM1HneVbR-S0YztXYsr3A@mail.gmail.com> References: <CACNAnaH=bfFDy0rgO2_VPtx3U6k6uwM1HneVbR-S0YztXYsr3A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hmr7bsJlnkk7QaOGCefA7n1EbfDMhnhwh Content-Type: multipart/mixed; boundary="nTL3PBaj04h6AWi8ToOB5r4fxTCpaCNTp"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: Kyle Evans <kevans91@ksu.edu>, ports-list freebsd <freebsd-ports@freebsd.org> Message-ID: <a7c84b19-0b61-0584-0bad-ef0ecfc2864c@FreeBSD.org> Subject: Re: qa.sh stripped warning References: <CACNAnaH=bfFDy0rgO2_VPtx3U6k6uwM1HneVbR-S0YztXYsr3A@mail.gmail.com> In-Reply-To: <CACNAnaH=bfFDy0rgO2_VPtx3U6k6uwM1HneVbR-S0YztXYsr3A@mail.gmail.com> --nTL3PBaj04h6AWi8ToOB5r4fxTCpaCNTp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 12/10/2016 =C3=A0 16:29, Kyle Evans a =C3=A9crit : > Hello! > > I've got a port with a dozen+ ELF binaries for microcontroller > firmware that I don't think I should be stripping, but qa.sh does not > like this. They're *.elf and *.lib files, so I don't know that adding > these to the general exception of `find` in stripped() is necessarily > a good idea, but it seems like a way to add exceptions for this would > it be a good idea, whether it be through some setting in the port or > on a case-by-case basis in the pkg-plist.. thoughts? > > My main concern here is that I don't intend to strip these, but the > comment for stripped() would leave me to believe that there's a chance > these warnings could eventually turn into errors, and I don't want > this to be the case if it's not something that should be stripped. The warning will never be turned into errors. Maybe add a comment to the makefile saying that files must not be stripped. Maybe a bit like go ports do it, something like: STRIP=3D # Elf firmwares, do not strip Which also disables the qa warnings. --=20 Mathieu Arnold --nTL3PBaj04h6AWi8ToOB5r4fxTCpaCNTp-- --hmr7bsJlnkk7QaOGCefA7n1EbfDMhnhwh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJX/lhHXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IbXwQAK1/UXXN5xVNuFiHGEGKeGKE 8NBoGYirSrkThIHLYcvo3qDeVIrDqCA9p72etxQDo8w8M83BQRDGGvi10JjPAknE g2TopKRQITBywtZDqtJxXgnAm7g+0YKPoU/5PYSb0lr7XK4RXFYF0c96XoBFxZNM vYy1g5GfoFGjlLt6ceVce8DuWX+cI8VbV5CH8wY7uHaFLFsIk9vYl3PzyebuCZVw 9UM9uNzR5ZNqAMC0jvWxOykIwE7zptf8qR6R2vh90gbyjHnC7ELkOXK+Wjw8+xPw lDdaBQ2t0V9oQRp86yvB0ogkUszAkyV1qSTq6G8E24u86XGCW1KMkwZdao77gw/E zgqWjiDCgQ/ZPwDwe4eEaMjqHZG0gidrnqA8fTHnAMdVv8e4tEZ226k58MLYmINw vLxid4R26MqVgRAdroTJV6260WhYM2ntslexZljMzY54YcTr9nPMUyo2b+oTbKxy hbPidIvxGE139HWCn9iCZL8hf7cevu4vzw3cezESwwCy8na45Znp14bolWJmm1YQ rqnLomP+X7oDiCjc1bShwvuViRChOeY+PKDbwvyyua8triQD39oOUMPAPeKMaVhp QC4S3UEd1eCORnMvV9ZgrwgJlVb9hli2hr0obH0VqYmtKfMRIzmiBo9yF46ukWdg 4/S9XTP7qEvffaigVuRP =yndS -----END PGP SIGNATURE----- --hmr7bsJlnkk7QaOGCefA7n1EbfDMhnhwh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a7c84b19-0b61-0584-0bad-ef0ecfc2864c>