Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Jan 2022 16:19:16 +0000
From:      Rene Ladan <rene@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        Richard Gallamore <ultima@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 9f1b1be53d96 - main - *: Updated guacamole-[server|client] to 1.4.0
Message-ID:  <YdxchP0eBaLe2KTI@freefall.freebsd.org>
In-Reply-To: <Ydv51Io7dK0Vx1Bb@FreeBSD.org>
References:  <202201092309.209N9lFf039776@gitrepo.freebsd.org> <YduWxlKfqjJPRfTm@FreeBSD.org> <Ydvr85vbKEsP5gKi@freefall.freebsd.org> <Ydv51Io7dK0Vx1Bb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 10, 2022 at 09:18:12AM +0000, Alexey Dokuchaev wrote:
> On Mon, Jan 10, 2022 at 08:18:59AM +0000, Rene Ladan wrote:
> > On Mon, Jan 10, 2022 at 02:15:34AM +0000, Alexey Dokuchaev wrote:
> > > On Sun, Jan 09, 2022 at 11:09:47PM +0000, Richard Gallamore wrote:
> > > > commit 9f1b1be53d965ca9eedef7a6547eb47973c8dae0
> > > > 
> > > >     *: Updated guacamole-[server|client] to 1.4.0
> > > 
> > > There's no need to mutilate commit logs with `*:' anymore, JFYI.
> > 
> > Talking about mutilating commit logs, how about using the contents
> > of COMMENT as the first line of the commit log of newly added ports
> > instead of a non-informative "new port has been added (+)" ?
> 
> This is not mutilation: this won't work as COMMENT alone does not
> constitute *action* inflicted on the port, and amending the COMMENT
> with extra text to make it suitable for action won't fit the line
> limit, which is even less than common ~72 characters due to stupid
> four-characted padding git puts in front of the log.
> 
Having a short description of what the port does is more useful
than forcing the git summary in an active tense.

René



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YdxchP0eBaLe2KTI>