From owner-freebsd-hackers@FreeBSD.ORG Mon Mar 30 22:57:24 2015 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A30EBC8B for ; Mon, 30 Mar 2015 22:57:24 +0000 (UTC) Received: from mail.metricspace.net (mail.metricspace.net [IPv6:2001:470:1f11:617::103]) by mx1.freebsd.org (Postfix) with ESMTP id 78EB9754 for ; Mon, 30 Mar 2015 22:57:24 +0000 (UTC) Received: from [172.16.1.67] (unknown [172.16.1.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: eric) by mail.metricspace.net (Postfix) with ESMTPSA id A63002E5E0 for ; Mon, 30 Mar 2015 22:57:23 +0000 (UTC) Message-ID: <5519D4D3.6080707@metricspace.net> Date: Mon, 30 Mar 2015 18:57:23 -0400 From: Eric McCorkle User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org Subject: Re: ZFS support for EFI References: <55189CBA.9040107@metricspace.net> <543637C0-A4FF-4801-BE5C-859F2D968D48@me.com> In-Reply-To: <543637C0-A4FF-4801-BE5C-859F2D968D48@me.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 22:57:24 -0000 On 03/30/2015 12:28 AM, Rui Paulo wrote: >> First, I've converted boot1.c (the EFI boot block) to use an FS module >> framework. This facilitates the addition of ZFS, and should also come >> in handy if someone wants to add other functionality later (ie. crypto, >> netboot, etc.) > > Good. :-) Actually, would that be a good patch in its own right? I could certainly strip out the ZFS-related stuff for folks with UFS+EFI systems to test. (I only have ZFS drives myself) > I have a crazy idea: why not use getopt() in loader.efi ? getopt() is already part of libstand, so it should be easy to use it. > > Alternatively you can just use key value pairs. > I did a little more lookung. Turns out, I had it wrong. The old ZFS loader loads and parses /boot/config, not /boot/loader.conf. It appears that the existing EFI loader is ignoring /boot/config. Is that intentional, or just missing functionality? (It would probably make more sense to stash /boot/config or its analog on the ESP anyway.)