From owner-p4-projects  Thu Dec 12 10:44: 1 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id CAC2F37B406; Thu, 12 Dec 2002 10:43:59 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6228537B401
	for <perforce@freebsd.org>; Thu, 12 Dec 2002 10:43:59 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E84FD43ED4
	for <perforce@freebsd.org>; Thu, 12 Dec 2002 10:43:58 -0800 (PST)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gBCId1mV055843
	for <perforce@freebsd.org>; Thu, 12 Dec 2002 10:39:01 -0800 (PST)
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gBCId1B9055840
	for perforce@freebsd.org; Thu, 12 Dec 2002 10:39:01 -0800 (PST)
Date: Thu, 12 Dec 2002 10:39:01 -0800 (PST)
Message-Id: <200212121839.gBCId1B9055840@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
Subject: PERFORCE change 22212 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=22212

Change 22212 by marcel@marcel_nfs on 2002/12/12 10:38:48

	Don't define baudrate as a 64-bit type. The structure is not
	64-bit "clean". Using packed would only cause unaligned access
	faults. This was already done for the 64-bit address, but I
	missed baudrate.

Affected files ...

.. //depot/projects/ia64/sys/ia64/include/dig64.h#2 edit

Differences ...

==== //depot/projects/ia64/sys/ia64/include/dig64.h#2 (text+ko) ====

@@ -36,7 +36,7 @@
 	uint8_t		_reserved_;
 	/*
 	 * XXX using a 64-bit type for the address would cause padding and
-	 * using __packed will cause unaligned accesses...
+	 * using __packed would cause unaligned accesses...
 	 */
 	uint32_t	addr_low;
 	uint32_t	addr_high;
@@ -57,7 +57,12 @@
 	uint8_t		_reserved2_:3;
 	uint8_t		interrupt:1;
 	uint8_t		pci_flag:1;
-	uint64_t	baudrate;
+	/*
+	 * XXX using a 64-bit type for the baudrate would cause padding and
+	 * using __packed would cause unaligned accesses...
+	 */
+	uint32_t	baud_low;
+	uint32_t	baud_high;
 	struct dig64_gas address;
 	uint16_t	pci_devid;
 	uint16_t	pci_vendor;

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message