From nobody Wed Oct 19 13:04:35 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MsrW00nhXz4fvC6; Wed, 19 Oct 2022 13:02:52 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MsrVw5GTPz3G2G; Wed, 19 Oct 2022 13:02:48 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 3A1791D291A; Wed, 19 Oct 2022 15:02:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anongoth.pl; s=ANONGOTH; t=1666184550; bh=HivvvtuaQjgnzQnQKRk4D5L8/E9jTsGHcOjdBgmyGX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=cx0fyzp3v2Xx2W9Mhh2KkBsMBjq232wzBC1JRpQeMm286woTeUAcqCMxWuj9Xt4HI I8WJZepsyAUbajr6FmvKQoo9kd+Cx3pT++q2k8NdACC+pwrJSqL2lsW4g7CZdsNy9Z PFya5nA9X9PJit0cpEuO2kie5zGBZ6Gugg58VedBTo4MdvjUl2tfNzjRsydh1GxpYn rbEUF/uIItJRzNEvV2m3mfgaESVRoYT6RU2ADMgr06RE7sIj2B/8P2vq+zDr6/W5cw 0xhhIEmb0Ul3qCb1Ic+QE/lonarubQm50/FvS1NpUeMIZtCqPWmCkGIJ3gzCDeBxGc fnyFbcjL0mf6Q== Date: Wed, 19 Oct 2022 15:04:35 +0200 From: Piotr Kubaj To: Kirill Ponomarev Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 8177b0385384 - main - devel/pcre: Adding option to disable jit support Message-ID: References: <202210190929.29J9Ta0X066965@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qmip8X741ZXnqoF/" Content-Disposition: inline In-Reply-To: <202210190929.29J9Ta0X066965@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4MsrVw5GTPz3G2G X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=anongoth.pl header.s=ANONGOTH header.b=cx0fyzp3; dmarc=pass (policy=reject) header.from=anongoth.pl; spf=pass (mx1.freebsd.org: domain of pkubaj@anongoth.pl designates 46.248.190.61 as permitted sender) smtp.mailfrom=pkubaj@anongoth.pl X-Spamd-Result: default: False [-5.59 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.996]; NEURAL_HAM_SHORT(-1.00)[-0.996]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_DKIM_ALLOW(-0.20)[anongoth.pl:s=ANONGOTH]; MLMMJ_DEST(0.00)[dev-commits-ports-all@FreeBSD.org,dev-commits-ports-main@FreeBSD.org]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[pkubaj]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[anongoth.pl:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --Qmip8X741ZXnqoF/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Why enable JIT by default only on some architectures that work with it? It should either be disabled on all by default, or enabled on all that support it. On 22-10-19 09:29:36, Kirill Ponomarev wrote: > The branch main has been updated by krion: >=20 > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D8177b0385384c4561e31c969= 8a1eb25ffdf720eb >=20 > commit 8177b0385384c4561e31c9698a1eb25ffdf720eb > Author: Kirill Ponomarev > AuthorDate: 2022-10-19 09:28:44 +0000 > Commit: Kirill Ponomarev > CommitDate: 2022-10-19 09:28:44 +0000 >=20 > devel/pcre: Adding option to disable jit support > =20 > PR: 267174 > Reported by: olivier > --- > devel/pcre/Makefile | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) >=20 > diff --git a/devel/pcre/Makefile b/devel/pcre/Makefile > index fb9a2b63b98b..1bda6e50aef1 100644 > --- a/devel/pcre/Makefile > +++ b/devel/pcre/Makefile > @@ -1,6 +1,6 @@ > PORTNAME=3D pcre > PORTVERSION=3D 8.45 > -PORTREVISION=3D 1 > +PORTREVISION=3D 2 > CATEGORIES=3D devel > MASTER_SITES=3D https://ftp.pcre.org/pub/pcre/ \ > SF > @@ -31,16 +31,23 @@ TEST_TARGET=3D check > =20 > PORTDOCS=3D * > =20 > -OPTIONS_DEFINE=3D DOCS MAN3 STACK_RECURSION > +OPTIONS_DEFINE=3D DOCS JIT MAN3 STACK_RECURSION > OPTIONS_DEFAULT=3D MAN3 STACK_RECURSION > -OPTIONS_SUB=3D yes > +OPTIONS_DEFAULT_aarch64+=3D JIT > +OPTIONS_DEFAULT_amd64+=3D JIT > +OPTIONS_DEFAULT_i386+=3D JIT > +OPTIONS_DEFAULT_mips+=3D JIT > =20 > OPTIONS_RADIO=3D CLI > OPTIONS_RADIO_CLI=3D LIBEDIT READLINE > +OPTIONS_SUB=3D yes > =20 > +JIT_DESC=3D Use the JIT compiler (not available on all platforms) > MAN3_DESC=3D Install API manpages (section 3) > STACK_RECURSION_DESC=3D Use the stack for recursion during matching > =20 > +JIT_CONFIGURE_ENABLE=3D jit > + > LIBEDIT_USES=3D libedit > LIBEDIT_CONFIGURE_ENABLE=3D pcretest-libedit > =20 > @@ -84,12 +91,6 @@ CONFIGURE_ARGS+=3D --with-parens-nest-limit=3D${WITH_P= ARENS_NEST_LIMIT} > CONFIGURE_ARGS+=3D --with-posix-malloc-threshold=3D${WITH_POSIX_MALLOC_T= HRESHOLD} > .endif > =20 > -.if ${ARCH} !=3D "sparc64" && empty(ARCH:Mmips64*) && empty(ARCH:Mriscv6= 4*) > -CONFIGURE_ARGS+=3D --enable-jit > -.else > -CONFIGURE_ARGS+=3D --disable-jit > -.endif > - > post-patch: > @${REINPLACE_CMD} -e "/^\.rs/d" ${WRKSRC}/doc/*.3 ${WRKSRC}/doc/*.1 > @${REINPLACE_CMD} -e "s/=C2=A3//g" ${WRKSRC}/doc/pcre_compile2.3 --Qmip8X741ZXnqoF/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmNP9eMACgkQelmbhSCD nJ2oJw//YgeNkg42yPsq+f3ISyyl6ETiGzgXwqpcXSl+D8fQ6jbBQFPpaz2k/4AL H0GbGr8p+9/HyrRNgNJe89p2XDk216h96r1xZVr0FdyMGIt2kysbPd44frT3Lryg ihvhYaDwxy4lkH0lHsBT3Lxdd7arKtqyBrTQmVjTPuhs93yXZYPodA4Wb8Ubb3Ri KTyBbsmXWADabtRQPYcBWs3B/2bDPUgPgEZrXWNoTjdrbDSHzvTSek8D9Vo2/mni 33A23XkED2lrFXB8Vpj0zrynWqoSzSuIyoql0lGK9c6X4gSP03XLSGNRqLcXqoQ7 Sh9/96Y7aShNbEaCb2HdO2hbqwwYbWWOnVY4NiMO81z+NsRpjeD8Sy0HmEahUcLH yBhSrgLTFXgvdMN5w5bQX0+45MSmg8iZOQfNmxjsDEaFmliZYzYXM3Hf5fWYYf/6 i3QyTy2DcIztgZqwfVlP42EmUV4rUmPka3cCHjc1aEx9jYFMsYRTGMt8RM2Innlh ZSdhJl8DqFq+FBcMg7aLd98grcfi+61h/+O++TCPDsvnNzvAtW9Uf25D4vdHPcVc OsctYAijcNx5agzqmetw7GdAPdtLFOghQ0k7aiC1yl1IbCAMN9/dHWrDIwcpHLdP tUqq/TKubP7njL8bXdtTe8zTU7flBb2HYgxwaYdk2t5kXl/4vpA= =PUD1 -----END PGP SIGNATURE----- --Qmip8X741ZXnqoF/--