From owner-freebsd-bugs@freebsd.org Wed Dec 16 11:36:15 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3C05A4B93C7 for ; Wed, 16 Dec 2020 11:36:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CwtPC0zlHz4mwD for ; Wed, 16 Dec 2020 11:36:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 1FFE64B93C6; Wed, 16 Dec 2020 11:36:15 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1FC464B93C5 for ; Wed, 16 Dec 2020 11:36:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CwtPC0Lyrz4mt1 for ; Wed, 16 Dec 2020 11:36:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EF48E2561E for ; Wed, 16 Dec 2020 11:36:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0BGBaEPa048859 for ; Wed, 16 Dec 2020 11:36:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0BGBaEYZ048858 for bugs@FreeBSD.org; Wed, 16 Dec 2020 11:36:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 251868] Add tcgetwinsize() and tcsetwinsize() to termios.h Date: Wed, 16 Dec 2020 11:36:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: 0.gangzta@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2020 11:36:15 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251868 --- Comment #7 from SOUMENDRA GANGULY <0.gangzta@gmail.com> --- Sir, I have created a phabricator account. Can you please approve it? The e= mail address is the same as that of this Bugzilla account. I have made an observation. Both the NetBSD and the OpenBSD versions of termios.h only have sys/ttydefaults.h in the last block after the #endif /* !_TERMIOS_H_ */: https://github.com/NetBSD/src/blob/trunk/sys/sys/termios.h https://github.com/openbsd/src/blob/master/sys/sys/termios.h glibc does something similar: https://github.com/bminor/glibc/blob/master/termios/termios.h although their sys/ttydefaults.h is being included in the protected block. FreeBSD's termios.h was changed from https://svnweb.freebsd.org/base/head/include/termios.h?revision=3D191882&vi= ew=3Dmarkup to https://svnweb.freebsd.org/base/head/include/termios.h?revision=3D199898&vi= ew=3Dmarkup when ttycom.h suddenly got moved to the last block; there is no explanation= in the SVN "commit message" as to why that was done. I suspect that it was a mistake. If you think that my claim is correct, then I will replace the #include in my diff with a #include and remove the #inc= lude from the final block; sys/ttycom.h contains the definition of struct winsize needed for tcgetwinsize() and tcsetwinsize(). Basically, the= n it will look like the NetBSD header: https://github.com/NetBSD/src/blob/trunk/sys/sys/termios.h Thank you for your time. --=20 You are receiving this mail because: You are the assignee for the bug.=