From nobody Thu Oct 19 21:41:01 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBLkQ0nk8z4xvLn; Thu, 19 Oct 2023 21:41:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBLkP64bkz4Q0T; Thu, 19 Oct 2023 21:41:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697751661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KC6pOcXaRG96ck0lDX2/7aZC3GX6tEth/FjEg4lcSww=; b=NGsfIL0K3QTii0cKf1kOMmdkfgf2fG1uZvG7cIvybNJODPDAHhqYqpmyjFuSbMEAp6cyye oX798Um7QE+7mSNj8RbjW2PGrpv5ZEnfvbFJ4begkqBHU9zVQhIfS9nekN0qRVOE0PQiY1 yU7TF995OIzIUb9/BstofXqUrf9/iJw0hju2xKtUljAJYt/dnITOHQ4F62Y7h579uhxsl6 2etYgqtASp33vifBRok16Rty0OEfYEqCcZLGDbBZc3VsZYX7dBEeBw5vTvuXwbdeCyqDj4 JST2F+1OQE8QYoKS0EWwPdvviGKrMbZK2IaQAdotS4hOc5uCgPTlFLydrvciBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697751661; a=rsa-sha256; cv=none; b=wQ359VjzsWTkBSd82adRshmmonoOtFVi3xWIi/pfbBoqNkh+1kKIZTT+GuRNoFYSRy6aub 5OgVf+RZ3N5cCoMfQmJbksHnHZXKhUHFj5BoCnLITwGS814mfp7NkhcC7mWIh/1E0bLHRo 5qn+yU7Xlo69mDhk75O7PNiZP5clH1IZEmnIcdpASUizOmaj6EzOzusxzR2n9GwyA/vBvR a2cfT4T2UjlS4vJO/BqpPAcR4LJ64rrlMxt7x9ffVwd7g/yD2LVZzkRG9rRwZuH0U4znMF a2wBIy+ZhukpiKWw75/spVYBy9VcEHlDpVt1Xi5YaqjiZHQi/54onOXBiniKGA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697751661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KC6pOcXaRG96ck0lDX2/7aZC3GX6tEth/FjEg4lcSww=; b=kQmoB1q96BA0XMJzmjEcZK4B69sAGBg/YcdCCUZJgITe9wzBc1cE3/yXl9XgkNMrfrfZPK srWVDGAomSeCMkI8qdYFEHJd8kRemiuyX8yKQkUNQDgi/D0ObbuXilTkKmyzZD4PBrhRzU OfipyFKwZP7Oe9XB1f4KF+s3gGUCJFNk/M/4bdnMuBgu6hlKvidbw0X1ivVK/Y5zjztyHj Ur7+Xv2gbnYudrR7s9UfTl7azwOIjGPmAK3OcWjxtedoAoLmF/LmmYJZiO6bLlVvoX1HSi VkJG1jaHUHxePIXsbaRM6gc/E1QJJ27uPIHX9TP27Ry9VshpfTGBFi7S3p3J0w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SBLkP58Pbz15tH; Thu, 19 Oct 2023 21:41:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39JLf1U1002640; Thu, 19 Oct 2023 21:41:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39JLf1sY002637; Thu, 19 Oct 2023 21:41:01 GMT (envelope-from git) Date: Thu, 19 Oct 2023 21:41:01 GMT Message-Id: <202310192141.39JLf1sY002637@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: 0efd0d6fa7e0 - releng/14.0 - smartpqi: Change alignment for dma tags List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: 0efd0d6fa7e0d713ea7e4e9a3e3ac7858475f707 Auto-Submitted: auto-generated The branch releng/14.0 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=0efd0d6fa7e0d713ea7e4e9a3e3ac7858475f707 commit 0efd0d6fa7e0d713ea7e4e9a3e3ac7858475f707 Author: John Hall AuthorDate: 2023-10-19 03:25:32 +0000 Commit: Warner Losh CommitDate: 2023-10-19 21:37:33 +0000 smartpqi: Change alignment for dma tags Problem: Under certain I/O conditions, a program doing large block disk reads can cause a controller to crash. Root Cause: The SCSI read request and destination address in the BDMA descriptor is incorrect, causing the BDMA engine in the controller to assert. Fix: Change the alignment for creating bus_dma_tags in the driver from PAGE_SIZE (4k) to 1, which allows the controller to manage it's own address range for BDMA transactions. Risk: Medium Exposure: This reverts a change first made to support NVMe drives on Excalibur. At that time a 4k alignment was necessary. This no longer seems to be the case. PR: 259541 Reported by: Ka Ho Ng Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D41619 (cherry picked from commit f07b267d8cc87e88be3c78aa69504b5ebc6571ee) (cherry picked from commit 01619a8fafcfd99d1811b2c14a92bac1a48c6d31) Approved-by: re (gjb) --- sys/dev/smartpqi/smartpqi_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/smartpqi/smartpqi_main.c b/sys/dev/smartpqi/smartpqi_main.c index e79a6f0a173f..402841bbf4d6 100644 --- a/sys/dev/smartpqi/smartpqi_main.c +++ b/sys/dev/smartpqi/smartpqi_main.c @@ -629,8 +629,8 @@ smartpqi_attach(device_t dev) * Create DMA tag for mapping buffers into controller-addressable space. */ if (bus_dma_tag_create(softs->os_specific.pqi_parent_dmat,/* parent */ - PAGE_SIZE, 0, /* algnmnt, boundary */ - BUS_SPACE_MAXADDR,/* lowaddr */ + 1, 0, /* algnmnt, boundary */ + BUS_SPACE_MAXADDR, /* lowaddr */ BUS_SPACE_MAXADDR, /* highaddr */ NULL, NULL, /* filter, filterarg */ (bus_size_t)softs->pqi_cap.max_sg_elem*PAGE_SIZE,/* maxsize */