From owner-dev-commits-src-main@freebsd.org  Sat Jan  9 00:49:31 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 668044DB7E6;
 Sat,  9 Jan 2021 00:49:31 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DCLvv2b35z3lv4;
 Sat,  9 Jan 2021 00:49:31 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
Received: from [192.168.1.10] (c-98-207-126-143.hsd1.ca.comcast.net
 [98.207.126.143])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: rpokala)
 by smtp.freebsd.org (Postfix) with ESMTPSA id BD7EA5F8B;
 Sat,  9 Jan 2021 00:49:30 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
User-Agent: Microsoft-MacOutlook/16.44.20121301
Date: Fri, 08 Jan 2021 16:49:26 -0800
Subject: Re: 936440560bde - main - sysctl: implement debug.kdb.panic_str
From: Ravi Pokala <rpokala@freebsd.org>
To: Warner Losh <imp@FreeBSD.org>, <src-committers@FreeBSD.org>,
 <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
Message-ID: <C2F36E22-2B08-41F3-A583-BD01B2A7C169@panasas.com>
Thread-Topic: 936440560bde - main - sysctl: implement debug.kdb.panic_str
References: <202101082131.108LV4B1086024@gitrepo.freebsd.org>
In-Reply-To: <202101082131.108LV4B1086024@gitrepo.freebsd.org>
Mime-version: 1.0
Content-type: text/plain;
	charset="UTF-8"
Content-transfer-encoding: 7bit
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jan 2021 00:49:31 -0000

-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Warner Losh <imp@FreeBSD.org>
Date: 2021-01-08, Friday at 13:31
To: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
Subject: git: 936440560bde - main - sysctl: implement debug.kdb.panic_str

    The branch main has been updated by imp:

    URL: https://cgit.FreeBSD.org/src/commit/?id=936440560bde54050e1ad9daae3b9103e05ad3fc

    commit 936440560bde54050e1ad9daae3b9103e05ad3fc
    Author:     Warner Losh <imp@FreeBSD.org>
    AuthorDate: 2021-01-08 16:34:31 +0000
    Commit:     Warner Losh <imp@FreeBSD.org>
    CommitDate: 2021-01-08 21:30:28 +0000

        sysctl: implement debug.kdb.panic_str

...

    --- a/sys/kern/subr_kdb.c
    +++ b/sys/kern/subr_kdb.c
    @@ -109,6 +110,11 @@ SYSCTL_PROC(_debug_kdb, OID_AUTO, panic,
         kdb_sysctl_panic, "I",
         "set to panic the kernel");

    +SYSCTL_PROC(_debug_kdb, OID_AUTO, panic_str,
    +    CTLTYPE_STRING | CTLFLAG_RW | CTLFLAG_SECURE | CTLFLAG_MPSAFE, NULL, 0,
    +    kdb_sysctl_panic_str, "A",
    +    "set to panic the kernel with using the string as the panic message");

Might I suggest "trigger a kernel panic, using the provided string as the panic message".

Thanks,

Ravi (rpokala@)

    +
     SYSCTL_PROC(_debug_kdb, OID_AUTO, trap,
         CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_SECURE | CTLFLAG_MPSAFE, NULL, 0,
         kdb_sysctl_trap, "I",