From owner-cvs-src-old@FreeBSD.ORG Sun Oct 24 13:39:44 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 441E610656C7 for ; Sun, 24 Oct 2010 13:39:44 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2D45B8FC1B for ; Sun, 24 Oct 2010 13:39:44 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o9ODdiG4065649 for ; Sun, 24 Oct 2010 13:39:44 GMT (envelope-from marius@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o9ODdisg065648 for cvs-src-old@freebsd.org; Sun, 24 Oct 2010 13:39:44 GMT (envelope-from marius@repoman.freebsd.org) Message-Id: <201010241339.o9ODdisg065648@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to marius@repoman.freebsd.org using -f From: Marius Strobl Date: Sun, 24 Oct 2010 13:39:26 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_7 Subject: cvs commit: src/sys/dev/dc dcphy.c pnphy.c src/sys/dev/mii acphy.c amphy.c atphy.c bmtphy.c brgphy.c ciphy.c e1000phy.c exphy.c gentbi.c icsphy.c inphy.c ip1000phy.c jmphy.c lxtphy.c mii.c mlphy.c nsgphy.c nsphy.c nsphyter.c pnaphy.c qsphy.c rgephy.c ... X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Oct 2010 13:39:44 -0000 marius 2010-10-24 13:39:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/dc dcphy.c pnphy.c sys/dev/mii acphy.c amphy.c atphy.c bmtphy.c brgphy.c ciphy.c e1000phy.c exphy.c gentbi.c icsphy.c inphy.c ip1000phy.c jmphy.c lxtphy.c mii.c mlphy.c nsgphy.c nsphy.c nsphyter.c pnaphy.c qsphy.c rgephy.c rlphy.c rlswitch.c ruephy.c tdkphy.c tlphy.c truephy.c ukphy.c xmphy.c Log: SVN rev 214267 on 2010-10-24 13:39:26Z by marius MFC: r213364 - In the spirit of previous simplifications factor out the checks for a different PHY instance being selected and isolation out into the wrappers around the service methods rather than duplicating them over and over again (besides, a PHY driver shouldn't need to care about which instance it actually is). - Centralize the check for the need to isolate a non-zero PHY instance not supporting isolation in mii_mediachg() and just ignore it rather than panicing, which should sufficient given that a) things are likely to just work anyway if one doesn't plug in more than one port at a time and b) refusing to attach in this case just leaves us in a unknown but most likely also not exactly correct configuration (besides several drivers setting MIIF_NOISOLATE didn't care about these anyway, probably due to setting this flag for no real reason). - Minor fixes like removing unnecessary setting of sc->mii_anegticks, using sc->mii_anegticks instead of hardcoded values etc. Revision Changes Path 1.32.2.5 +1 -21 src/sys/dev/dc/dcphy.c 1.21.2.4 +1 -21 src/sys/dev/dc/pnphy.c 1.21.2.3 +2 -19 src/sys/dev/mii/acphy.c 1.22.2.4 +2 -27 src/sys/dev/mii/amphy.c 1.1.2.6 +2 -26 src/sys/dev/mii/atphy.c 1.12.2.3 +2 -29 src/sys/dev/mii/bmtphy.c 1.70.2.16 +10 -30 src/sys/dev/mii/brgphy.c 1.9.2.5 +2 -25 src/sys/dev/mii/ciphy.c 1.18.2.18 +1 -23 src/sys/dev/mii/e1000phy.c 1.23.2.3 +5 -21 src/sys/dev/mii/exphy.c 1.3.2.4 +2 -27 src/sys/dev/mii/gentbi.c 1.1.2.3 +2 -18 src/sys/dev/mii/icsphy.c 1.17.2.2 +1 -14 src/sys/dev/mii/inphy.c 1.2.2.8 +3 -25 src/sys/dev/mii/ip1000phy.c 1.1.2.3 +2 -26 src/sys/dev/mii/jmphy.c 1.19.2.4 +2 -26 src/sys/dev/mii/lxtphy.c 1.29.2.3 +33 -2 src/sys/dev/mii/mii.c 1.22.2.4 +4 -33 src/sys/dev/mii/mlphy.c 1.24.2.3 +1 -26 src/sys/dev/mii/nsgphy.c 1.28.2.5 +2 -26 src/sys/dev/mii/nsphy.c 1.1.2.4 +1 -25 src/sys/dev/mii/nsphyter.c 1.18.2.2 +3 -30 src/sys/dev/mii/pnaphy.c 1.18.2.3 +2 -20 src/sys/dev/mii/qsphy.c 1.15.2.8 +2 -25 src/sys/dev/mii/rgephy.c 1.31.2.3 +5 -20 src/sys/dev/mii/rlphy.c 1.1.2.2 +5 -18 src/sys/dev/mii/rlswitch.c 1.6.2.2 +5 -26 src/sys/dev/mii/ruephy.c 1.22.2.3 +2 -27 src/sys/dev/mii/tdkphy.c 1.22.2.3 +0 -23 src/sys/dev/mii/tlphy.c 1.1.2.5 +5 -34 src/sys/dev/mii/truephy.c 1.20.2.3 +2 -27 src/sys/dev/mii/ukphy.c 1.21.2.2 +6 -36 src/sys/dev/mii/xmphy.c