From owner-freebsd-wireless@freebsd.org Wed Dec 14 12:43:39 2016 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C380EC76532 for ; Wed, 14 Dec 2016 12:43:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 994FC1D97 for ; Wed, 14 Dec 2016 12:43:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uBEChdvw096434 for ; Wed, 14 Dec 2016 12:43:39 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-wireless@FreeBSD.org Subject: [Bug 215301] ifconfig list scan still abbreviates some SSID in -v mode Date: Wed, 14 Dec 2016 12:43:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ms-freebsd-bugzilla@stoffnet.at X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-wireless@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 12:43:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215301 Bug ID: 215301 Summary: ifconfig list scan still abbreviates some SSID in -v mode Product: Base System Version: 11.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: wireless Assignee: freebsd-wireless@FreeBSD.org Reporter: ms-freebsd-bugzilla@stoffnet.at A SSID with the maximum length of 32 characters will be abbreviated by "list scan", even when in verbose mode (using "-v" switch) (BSSID changed for privacy): > ifconfig -v wlan0 list scan SSID/MESH ID BSSID CHAN RATE S:N INT DIRECT-88-HP DeskJet 3630 se... fc:3f:db:ff:ff:ff 1 54M -87:-95 100 This is because list_scan() assumes the maximum SSID length (ssidmax) to be "IEEE80211_NWID_LEN - 1" in verbose mode. Changing this to "IEEE80211_NWID_= LEN" will lead to the expected behavior of displaying the full SSID: > ifconfig -v wlan0 list scan SSID/MESH ID BSSID CHAN RATE S:N I= NT DIRECT-88-HP DeskJet 3630 series fc:3f:db:ff:ff:ff 1 54M -87:-95 1= 00 This change should be safe, as the "ssid" variable, which is used to store = that value, is already initialized with the correct size (IEEE80211_NWID_LEN+1). Here is a unified diff with my suggested fix: --- sbin/ifconfig/ifieee80211.c.orig 2016-12-14 13:12:15.883264000 +0100 +++ sbin/ifconfig/ifieee80211.c 2016-12-14 13:12:36.495865000 +0100 @@ -3311,7 +3311,7 @@ getchaninfo(s); - ssidmax =3D verbose ? IEEE80211_NWID_LEN - 1: 14; + ssidmax =3D verbose ? IEEE80211_NWID_LEN: 14; printf("%-*.*s %-17.17s %4s %4s %-7s %3s %4s\n" , ssidmax, ssidmax, "SSID/MESH ID" , "BSSID" --=20 You are receiving this mail because: You are the assignee for the bug.=