From nobody Thu Apr 18 19:54:41 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VL7m13TDrz5HTdX for ; Thu, 18 Apr 2024 19:54:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VL7m10Cdyz4Hfj for ; Thu, 18 Apr 2024 19:54:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a526d381d2fso419559066b.0 for ; Thu, 18 Apr 2024 12:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1713470094; x=1714074894; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Q6Rt0NQ/Os3OQZu5y59Bm86y+3VzxYmneeUfMl87wtw=; b=zuyDZt4x6Nc+ExgJV+TrL/n/3WnaZWjs6eWINQlHa4M6v6WQ1pop82bcoNvsTTHXVC PsWpf3mxFAd78mdPojio/jNQ3euIBKI7Ku8H4HR983xBY+xyMS4h+ldthZJpgop/8Okg vVU1MOAqpD8WnjG2iixEHWn67MoDZMCNjZzQpSAqgjAQhTpt21XYu5LKqu9PcWZ3qJa2 /Jis2B7lUqhAE8DUp3+Wd5rDDu6Nu9BUe8fJ5gPac54Lu/2LEOy7W4u5xCft5s+aohji M7ap2VLOWwsXvhxtVLLVukh3vntQraUEKVPRNajXvRJfti38ZL3vl3zC7+ywe0l/PTVK wgUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713470094; x=1714074894; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q6Rt0NQ/Os3OQZu5y59Bm86y+3VzxYmneeUfMl87wtw=; b=wmUw6fd5VVr63J2Ht0Rl12aTU/H0wyLRgDWPpKBeHKTyk3rzn1gnBNWiwj4YLJO5jE G1slMNBwP/mbwel00fjO/M4HXRwa6QYsQQLErLU+ZQFl1vRxv+tVKdDju9/hEnU4xk4+ L0tgwV/fM6uRP4UeZQ4hD7Y0vRSKfLZ3vH/YNG+f/j3N5F4QX2fRdHg/eLX60ceUbvrD KjcPaYp66fwFCGLv4xIUg87BiU+wCc5aFxYbc99ikoybtTGVesnEluKaXWE2gyPC31zv +E8oj9fKHlXyhWNNr3mA181pFUDmkkacMDs76dLnJh/je/DqSbPsCu1TIK+FSr8Y3/gs XJ8g== X-Forwarded-Encrypted: i=1; AJvYcCVNdzgul7jiTwkk+SyIdXt6HxrXcoXKgbzCfrpBFVYzdspcfIFEAduV4ZMQSJHo7DiGl3otbPe2ok2M/uxkVti7tDKgHgNr2V15kpA4QGjQ X-Gm-Message-State: AOJu0YxonxAlX6NGGejpK4gN9pssgc7gF0kUP2ITnFY8wQVSUXodwiZP T68RNMeZvGnD7S/ewEFXdlpns2wsYVmWojuMcVyQLz3+ObsLQJRwQWJzPr+6dLaZKN0ugNDFAz4 lHzX3XuznWPYSRPJ6opfyDC0B7iGa+8in52P6a2fpswTkF877 X-Google-Smtp-Source: AGHT+IFoHiuwJcC9Q4AIuhkzn1EPOLFDR8yHL/Xn7YGjhmfoZJSWdgA3iSmc3k1VNHC/Qua4lKfTA0hK0vGf/79kicU= X-Received: by 2002:a17:906:c34c:b0:a55:6d17:6fbf with SMTP id ci12-20020a170906c34c00b00a556d176fbfmr196198ejb.5.1713470094124; Thu, 18 Apr 2024 12:54:54 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202404181857.43IIviHV084762@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 18 Apr 2024 13:54:41 -0600 Message-ID: Subject: Re: git: ede456359e55 - main - CONTRIBUTING: mention sys/crypto as another "contrib" directory To: John Baldwin Cc: Ed Maste , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000004b42250616645837" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VL7m10Cdyz4Hfj --0000000000004b42250616645837 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 18, 2024, 1:10=E2=80=AFPM John Baldwin wrote: > On 4/18/24 11:57 AM, Ed Maste wrote: > > The branch main has been updated by emaste: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dede456359e55958ab17ac665e586767= 4a0c0e81b > > > > commit ede456359e55958ab17ac665e5867674a0c0e81b > > Author: Ed Maste > > AuthorDate: 2024-04-18 18:44:30 +0000 > > Commit: Ed Maste > > CommitDate: 2024-04-18 18:57:19 +0000 > > > > CONTRIBUTING: mention sys/crypto as another "contrib" directory > > > > Reviewed by: imp > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D44857 > > Hmm, sys/crypto is a bit of a mixed bag there. openssl is a mix of > upstream > and local bits. libsodium is an upstream. chacha20 and blake2 I think a= re > upstreams. rijndael did come from an upstream but I don't think it's > alive. > > I'd actually prefer if we moved a lot of sys/crypto over to sys/dev, e.g. > actual device drivers (as opposed to software crypto implementations) lik= e > aesni, armv8, via, should definitely move to sys/dev. For sys/openssl it > might be nicer then to have the home-grown bits of ossl(4) that aren't fr= om > upstream in a sys/dev/ossl leaving the stock openssl bits in > sys/crypto/openssl. > I like this idea... git makes it easier... this area has historical been a hodgepodge.. Warner > --0000000000004b42250616645837 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Apr 18, 2024, 1:10=E2=80=AFPM John Baldwin <= ;jhb@freebsd.org> wrote:
On 4/18/24 11:57 AM, Ed Maste wrote:
> The branch main has been updated by emaste:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dede456359e55958ab17ac665e58676= 74a0c0e81b
>
> commit ede456359e55958ab17ac665e5867674a0c0e81b
> Author:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
> AuthorDate: 2024-04-18 18:44:30 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
> CommitDate: 2024-04-18 18:57:19 +0000
>
>=C2=A0 =C2=A0 =C2=A0 CONTRIBUTING: mention sys/crypto as another "= contrib" directory
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 imp
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0The FreeBSD Foundation >=C2=A0 =C2=A0 =C2=A0 Differential Revision: https:/= /reviews.freebsd.org/D44857

Hmm, sys/crypto is a bit of a mixed bag there.=C2=A0 openssl is a mix of up= stream
and local bits.=C2=A0 libsodium is an upstream.=C2=A0 chacha20 and blake2 I= think are
upstreams.=C2=A0 rijndael did come from an upstream but I don't think i= t's alive.

I'd actually prefer if we moved a lot of sys/crypto over to sys/dev, e.= g.
actual device drivers (as opposed to software crypto implementations) like<= br> aesni, armv8, via, should definitely move to sys/dev.=C2=A0 For sys/openssl= it
might be nicer then to have the home-grown bits of ossl(4) that aren't = from
upstream in a sys/dev/ossl leaving the stock openssl bits in sys/crypto/ope= nssl.

I like this idea... git makes it easier... this area has historical be= en a hodgepodge..

Warner= =C2=A0
--0000000000004b42250616645837--