From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar 12 17:34:20 2013
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id C994DD21;
 Tue, 12 Mar 2013 17:34:20 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-we0-x22e.google.com (mail-we0-x22e.google.com
 [IPv6:2a00:1450:400c:c03::22e])
 by mx1.freebsd.org (Postfix) with ESMTP id 444F45FE;
 Tue, 12 Mar 2013 17:34:20 +0000 (UTC)
Received: by mail-we0-f174.google.com with SMTP id r6so104490wey.5
 for <multiple recipients>; Tue, 12 Mar 2013 10:34:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
 :content-transfer-encoding;
 bh=r1XK8HymJvOCHuuBRNY91QWMR2xpq9Rqf7JkP6Xeh9Q=;
 b=lZa034s7oJ+LWXLwnIueHOW9YSGKP0yPoEmm2OPwNuR5IbXqxhOqZ3qCbIKYifLGoj
 190h5KcW1BbAngM/5xs8iD+AhKm5KFEWwRYAgLal44nw6m9Z6Z/vGiotOD+ZX2VEhDUR
 K/tqnFBeLkeTKLlrPFEoinDX6l71N8nC2ArQaQVWci+YeC5Bbvn2MltQj6UdCyJodAM3
 y0tvWK11XJn1K8vUndJhOwsk99y4HgNYQhjoT1NuohwnWt429I9czs+ljWGR/BUOqgP5
 oqNf3ou/1V5rCA3SJmJ09EwkMEMFmmf+yHpY/tkoGcZ82P55osLcSKK1nADfkW4Ao0tC
 9gKw==
MIME-Version: 1.0
X-Received: by 10.180.87.129 with SMTP id ay1mr21591702wib.1.1363109659416;
 Tue, 12 Mar 2013 10:34:19 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.216.111.201 with HTTP; Tue, 12 Mar 2013 10:34:19 -0700 (PDT)
In-Reply-To: <D4060110-61CB-49E3-9064-2A3F1FBAC27D@freebsd.org>
References: <CAJ-Vmonn1m_AMiJbxfGDM+XrpfF+LKunSeoUWgkF9QVaMKf5ew@mail.gmail.com>
 <D4060110-61CB-49E3-9064-2A3F1FBAC27D@freebsd.org>
Date: Tue, 12 Mar 2013 10:34:19 -0700
X-Google-Sender-Auth: lUJ9LZnpWBqG_47tHopYAfl2U7A
Message-ID: <CAJ-Vmo=8nUvuLCyGO9w_+w1Tbx6PhTgjz8B3R4MPOgkfiG+nmg@mail.gmail.com>
Subject: Re: clang - odd macro / conditional expansion behaviour?
From: Adrian Chadd <adrian@freebsd.org>
To: Dimitry Andric <dim@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@freebsd.org, Joerg Sonnenberger <joerg@britannica.bec.de>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Mar 2013 17:34:20 -0000

On 12 March 2013 00:52, Dimitry Andric <dim@freebsd.org> wrote:
> On Mar 12, 2013, at 04:17 , Adrian Chadd <adrian@freebsd.org> wrote:
>> In file included from
>> /usr/home/adrian/work/freebsd/ath/head/src/sys/modules/ath/../../contrib=
/sys/dev/ath/ath_hal/ar9300/ar9300_eeprom.c:21:
>> /usr/home/adrian/work/freebsd/ath/head/src/sys/modules/ath/../../contrib=
/sys/dev/ath/ath_hal/ar9300/ar9300template_generic.h:107:3:
>> error: implicit conversion from 'int' to
>>      'u_int8_t' (aka 'unsigned char') changes value from -477 to 35
>> [-Werror,-Wconstant-conversion]
>>                FREQ2FBIN(2412, 1),
>>                ^~~~~~~~~~~~~~~~~~
>> /usr/home/adrian/work/freebsd/ath/head/src/sys/modules/ath/../../contrib=
/sys/dev/ath/ath_hal/ar9300/ar9300eep.h:136:65:
>> note: expanded from macro 'FREQ2FBIN'
>>    (((y) =3D=3D HAL_FREQ_BAND_2GHZ) ? ((x) - 2300) : (((x) - 4800) / 5))
>>                                                   ~~~~~~~~~~~~~^~~
>
> I cannot find the exact code you are referencing here, but I assume it is=
 some sort of global initialization?  If so, this is most likely <http://ll=
vm.org/bugs/show_bug.cgi?id=3D10030>, which has been languishing in LLVM's =
Bugzilla for a way too long time. :-(
>

Yup it is, and yup it looks like this.



adrian