Date: Wed, 09 Dec 1998 17:21:36 +0900 From: okazaki@be.to To: billf@FreeBSD.ORG Cc: freebsd-ports@FreeBSD.ORG Subject: Re: ports/8859 Message-ID: <19981209172136B.okazaki@be.to> In-Reply-To: Your message of "Sun, 6 Dec 1998 13:35:48 -0800 (PST)" <199812062135.NAA00371@freefall.freebsd.org> References: <199812062135.NAA00371@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In Message-ID: <199812062135.NAA00371@freefall.freebsd.org>
Bill Fumerola <billf@FreeBSD.ORG> wrote :
> Synopsis: apache13 __FreeBSD_version is checked before its definition.
>
> State-Changed-From-To: open-closed
> State-Changed-By: billf
> State-Changed-When: Sun Dec 6 13:35:20 PST 1998
> State-Changed-Why:
> Pilot error. If you are tracking ports, you need to track your source.
I'm sorry for my snail response.
What I talked about in ports/8859 is a missing <osreldate.h> issue.
According to the handbook, we can use __FreeBSD_version for a compile-time
version checking like this:
#if (__FreeBSD_version>300004)
if ( !strncmp("nfs",fsbuf.f_fstypename,3) ) *fstype = ADIO_NFS;
#else
if (fsbuf.f_type == MOUNT_NFS) *fstype = ADIO_NFS;
#endif
I understand this style version check requires the __FreeBSD_version
macro has a valid value at a compile-time(right?). If we don't ensure
this precondition, consequences of `make build' can be mysterious.
Depending on the circumstances, we may fail in `make build' (such a port
is marked as BROKEN*,) `make install' seems OK but installed binaries
would not work well, or it works more by accident than design.
I think the apache13 port is caught by this minor pitfall, though
it is not marked as BROKEN*. (Please see the How-To-Repeat section.)
Anyway, I agree to your advise that I have to catch up to STABLE or
CURRENT. I will try to check that steps I wrote in the How-To-Repeat
section are repeatable or not on STABLE or CURRENT..
Thank you for comments.
Tetsurou
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19981209172136B.okazaki>