From owner-cvs-all@FreeBSD.ORG  Mon Aug  8 20:18:18 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 80A2716A420;
	Mon,  8 Aug 2005 20:18:18 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4739E43D48;
	Mon,  8 Aug 2005 20:18:18 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from freefall.freebsd.org (csjp@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j78KIIUq081094;
	Mon, 8 Aug 2005 20:18:18 GMT
	(envelope-from csjp@freefall.freebsd.org)
Received: (from csjp@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j78KIIKl081093;
	Mon, 8 Aug 2005 20:18:18 GMT (envelope-from csjp)
Date: Mon, 8 Aug 2005 20:18:18 +0000
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Nate Lawson <nate@root.org>
Message-ID: <20050808201817.GA73709@freefall.freebsd.org>
References: <200508081956.j78Jui1l095716@gw.catspoiler.org>
	<42F7BA45.4040700@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42F7BA45.4040700@root.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, Don Lewis <truckman@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_sysctl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2005 20:18:18 -0000

On Mon, Aug 08, 2005 at 01:02:13PM -0700, Nate Lawson wrote:
> 
> One other thing:  I don't think this should be MFCd before 6.0.  It's 
> possible that there are some drivers that violate this rule and having a 
> release trigger panics is bad.  This is the same reason we turn off 
> INVARIANTS for releases.
> 

iirc WITNESS_WARN will only result in a panic if WARN_PANIC, otherwise
just a warning is printed to the console. Further, WITNESS_WARN is a nop
if WITNESS has'nt been compiled into the kernel. I think this is safe
to MFC.

-- 
Christian S.J. Peron
csjp@FreeBSD.ORG
FreeBSD Committer