From owner-freebsd-mips@FreeBSD.ORG Thu Jun 17 15:48:43 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6D351065675; Thu, 17 Jun 2010 15:48:43 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d]) by mx1.freebsd.org (Postfix) with ESMTP id 3BA5B8FC12; Thu, 17 Jun 2010 15:48:43 +0000 (UTC) Received: from [192.168.1.69] (pool-70-109-12-150.atl.dsl-w.verizon.net [70.109.12.150]) (authenticated bits=0) by lakerest.net (8.14.3/8.14.3) with ESMTP id o5HFmTY4039953 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 17 Jun 2010 11:48:35 -0400 (EDT) (envelope-from rrs@lakerest.net) DKIM-Signature: a=rsa-sha1; c=simple/simple; d=lakerest.net; s=mail; t=1276789716; h=Cc:Message-Id:From:To:In-Reply-To:Content-Type: Content-Transfer-Encoding:Mime-Version:Subject:Date:References: X-Mailer; b=glnammWRP5pjneWUxxmjsljShz0L1D7dLEt0QV9DhqDsGG5bit9wz4X RetwxPM1MT5HoJWnmBVxSWJFCstPvQg== Message-Id: <98F8CB29-62FE-41A6-8AE6-6F8AF086D29C@lakerest.net> From: Randall Stewart To: "Jayachandran C." In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Thu, 17 Jun 2010 11:48:24 -0400 References: X-Mailer: Apple Mail (2.936) Cc: freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD - part 2 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2010 15:48:43 -0000 JC: I don't think renaming the PTE entries to PG_ is a good idea. Way back in 2007 this was one of the issues I hit.. the J code used PG_ and somewhere in the VM we used PG_ to indicate (Page). Thus we ended up with a PG_G defined in two places and we were setting PG_G and it was Not the PTE PG_G.. but the one defined in the VM. The folks in the VM world suggested we change this to PTE_xxx which I did. R On Jun 17, 2010, at 11:38 AM, Jayachandran C. wrote: > On Tue, Jun 15, 2010 at 7:06 PM, Jayachandran C. > wrote: >> I have volunteered to merge Juli's 64-bit work into HEAD, and >> hopefully get it to work on XLR too. The tree >> (http://svn.freebsd.org/base/user/jmallett/octeon) has quite a bit of >> changes, so I would like to do this over multiple changesets and >> without breaking the current o32 code. > > Here's part 2, containing two patches: > > pmap-PTE-to-PG.patch : > > This is a renaming patch with minor cleanup, The PTE_* flags are > renamed to PG_ and related changes are made to other files. I have > tried to make this patch limited to just the renaming and the changes > related to it. I will make another patch for the rest of the minor > changes in pmap.c. > > My comment on this patch: The name PG_C_CNC for value 3 in pte.h may > be confusing, at least on XLR. We don't have cached non-coherent mode, > the cached memory is coherent(except L1 I-cache), so I would prefer > PG_CACHED and PG_UNCACHED names. > > pmap-lgmem-lock-remove.patch : > > Remove the lock in local_sysmaps, and sched_pin()/unpin() in the > PMAP_LMEM_ macros. > > The 64-bit support changes would be next - comments on the patches > esp. the first one is welcome. > > Thanks, > JC. > ------------------------------ Randall Stewart 803-317-4952 (cell)