From owner-freebsd-arch@FreeBSD.ORG Thu Mar 25 09:56:27 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB8AE10656B9; Thu, 25 Mar 2010 09:56:27 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 20C398FC1F; Thu, 25 Mar 2010 09:56:27 +0000 (UTC) Received: from outgoing.leidinger.net (pD954FB2C.dip.t-dialin.net [217.84.251.44]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id BDB9A8455F7; Thu, 25 Mar 2010 10:56:19 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 5A60D5412; Thu, 25 Mar 2010 10:56:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1269510976; bh=A1Gd6pRdbcz1A2yfXSNvICIh7xEpcJWxZKYLCYHhMEk=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=qxgmbGH3QOiUJ2eCqY9w9lod+hg+QNdnjAGjfQ/VQrhWO+UvlGzxxtQ38BC/goLwa X/IfLWFw9LutcSsKeqDjg6RqkPBAVv2lSu8pfSaEiW6PDmbhMuzjoyPOEk1xHP2zbm DE4CwpGtQUcbkyE993k/tn/0UTg6iUYPFvFcV6/+ZXBtdloGQe/jQ/OzCr3DlmyN7K G4QXataKnh8SU7lHiYGQAiTGHbFhM04u/EPBsAmToiZ6ZR9kCUYfXImIHuCVYDghj8 OrlD7TiAWUAg/KMO2z7P+f1XB033UfMRmLFwRC+5WwFskS2TThdw98X7a6QeCVzP9x Pu1afEYFApplQ== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o2P9uGjr011233; Thu, 25 Mar 2010 10:56:16 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Thu, 25 Mar 2010 10:56:15 +0100 Message-ID: <20100325105615.10186jr08a5oj00s@webmail.leidinger.net> Date: Thu, 25 Mar 2010 10:56:15 +0100 From: Alexander Leidinger To: John Baldwin References: <20100322.125937.278730673160410010.imp@bsdimp.com> <201003241005.55239.jhb@freebsd.org> <20100324154214.16865r6wk0r22rcw@webmail.leidinger.net> <201003241132.29588.jhb@freebsd.org> In-Reply-To: <201003241132.29588.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: BDB9A8455F7.34F85 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.44, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1270115780.20329@8xeTu+yLILD0hSbMokbJXw X-EBL-Spam-Status: No Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2010 09:56:27 -0000 Quoting John Baldwin (from Wed, 24 Mar 2010 11:32:29 -0400): > On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote: >> Quoting John Baldwin (from Wed, 24 Mar 2010 10:05:55 > -0400): >> >> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote: >> >> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk >> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means >> >> that all makeoptions do not propagate to module builds. >> >> >> >> Any ideas? >> > >> > Hmmmm. That's odd because 'DEBUG=-g' does work. Ah, I think you should >> > patch kern.post.mk to propogate WITH_CTF to modules. This is how it works >> > for DEBUG now: >> > >> > .if defined(DEBUG) >> > MKMODULESENV+= DEBUG_FLAGS="${DEBUG}" >> > .endif >> >> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk >> instead of kernl.post.mk)? > > No, I think it is fine to treat it the same as DEBUG. DEBUG is in kern.pre.mk, and thus can be overriden. Currently I have WITH_CTF handling in kern.post.mk, and thus it can not be overriden. There are some MKMODULESENV things in post.mk already. On a related note, the LD_CTF_FLAGS thing does not seem to work for modules. Reading the man page of ld tells that -g is a noop (the switch is ignored). Thus I would prefer to remove the setting of -g for ld. Any objections? >> While I'm here, do we want to have CONF_CFLAGS used in modules too? I >> would expect that they are used there (I use it to use -fno-builtin >> for my kernel build) and would put it into kern.post.mk. > > Hmm, probably yes. That should be a separate commit however. I agree. Bye, Alexander. -- These days the necessities of life cost you about three times what they used to, and half the time they aren't even fit to drink. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137