From owner-svn-src-all@freebsd.org Sat Feb 4 04:12:48 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B196CD0B22; Sat, 4 Feb 2017 04:12:48 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qt0-x243.google.com (mail-qt0-x243.google.com [IPv6:2607:f8b0:400d:c0d::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EDD2C1486; Sat, 4 Feb 2017 04:12:47 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by mail-qt0-x243.google.com with SMTP id h53so8314146qth.3; Fri, 03 Feb 2017 20:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=bCbWnuAKfVf+lM7mvTpa5afRC47dyNjKFfA40qMLk3Y=; b=A8KQ18ySSa2oLfGkN7thNXnppErCAYWdSatcTS4kvnmxMwaYdSeWvKzCKgkBQgevCf ggEndMpGSZ5PDwz3FsGLjXVvwp/ff/0XckmE3z9dOqaaBvPfPG5XbRponSbEUJ2xn0R6 PDdBu+WPiKwHPXKXiF97dx400d7NUJ2MLn974ENL4ceCXiKmLxd6HZZ56uEqjbJ0RcV8 Qw7Vh9Mn45rs8DxVYjCcfZLucWZITZByiNojpiTfAHtSkeXWYEgaS6qSBMR/oPd8JlFT kManySAp6a+63wzlOLVajQpjzI5p2WZdPCKiZKwX5UEG7v7u5dwPfRVtys8i/PLDWHK0 O8Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=bCbWnuAKfVf+lM7mvTpa5afRC47dyNjKFfA40qMLk3Y=; b=F/SlbXQFgJAosKoP9erzxMTQTJimtlglg4PfmESk7eOXdW1MJ+jOviSCnNqgM7pQ7H /jTAm9Z5t+zGkVTgeGytncCVZ8XHARqRdHKLzgRSxWE1BIvUEkYtUTWtxBjDUwkZfIOa xURvzwsGeLxwJmq6luf8mKYErfKLU3O2VdAa1xiqmYiiPaxgAQI0cWDb9mANbq6yBnGC 4HWPajjT1h9F/0xGtgm3GRI9L317UB84+K64XHz1/F0r+Za5UgPM62YqDisVAbvLpst0 rJheoyhraPFPxFDPqPRxOBag5Drw34E4j+K8ibFPyU3mjFopypaacSSs/h3crtlJ48Iz yEEQ== X-Gm-Message-State: AMke39mO6oxRZuxdDO57DiSN5ejRd+Fz8pQljW1+YtOUWE+t12+mgnPFEhzpH569DvtwZQ== X-Received: by 10.200.43.115 with SMTP id 48mr372168qtv.157.1486181566715; Fri, 03 Feb 2017 20:12:46 -0800 (PST) Received: from kan ([2601:18f:802:4680:226:18ff:fe00:232e]) by smtp.gmail.com with ESMTPSA id d52sm26422460qtc.2.2017.02.03.20.12.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Feb 2017 20:12:43 -0800 (PST) Date: Fri, 3 Feb 2017 23:12:38 -0500 From: Alexander Kabaev To: "Jason A. Harmening" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313037 - in head/sys: amd64/include kern mips/include net powerpc/include sparc64/include Message-ID: <20170203231238.0675c289@kan> In-Reply-To: <201702010332.v113WnYf041362@repo.freebsd.org> References: <201702010332.v113WnYf041362@repo.freebsd.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.29; amd64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/qc8uWeVfq6fCjBto+huGfjq"; protocol="application/pgp-signature" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2017 04:12:48 -0000 --Sig_/qc8uWeVfq6fCjBto+huGfjq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 1 Feb 2017 03:32:49 +0000 (UTC) "Jason A. Harmening" wrote: > Author: jah > Date: Wed Feb 1 03:32:49 2017 > New Revision: 313037 > URL: https://svnweb.freebsd.org/changeset/base/313037 >=20 > Log: > Implement get_pcpu() for the remaining architectures and use it to > replace pcpu_find(curcpu) in MI code. >=20 > Modified: > head/sys/amd64/include/pcpu.h > head/sys/kern/kern_rmlock.c > head/sys/mips/include/pcpu.h > head/sys/net/netisr.c > head/sys/powerpc/include/cpufunc.h > head/sys/powerpc/include/pcpu.h > head/sys/sparc64/include/pcpu.h >=20 Hi, this change was not reviewed nor testing was thought for all architectures it touches. The change happens to break MIPS quite thoroughly, since MIPS is using different pointers when accessing PCPU area locally and when doing iterations using cpu_to_cpuid array. I therefore officially am requesting this change to be reverted until reasonable solution is found to unbreak architectures that use wired TLBs to access local per-CPU data. --=20 Alexander Kabaev --Sig_/qc8uWeVfq6fCjBto+huGfjq Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEExffZlZm2QeE8UVaRBxMimZJ5Ln4FAliVVLZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM1 RjdEOTk1OTlCNjQxRTEzQzUxNTY5MTA3MTMyMjk5OTI3OTJFN0UACgkQBxMimZJ5 Ln5C5BAAi+BeKHGRfGjrUvBD1Bkx6bRcIoFJMgrZ1bLrRtH+ibGeMeGnwnLwZ6Th lmkWFj1hDJ0UEem6KXtyM+8LQm0BKkJr+5Vc6Fdt9QDIAmagsct6jpQFgmh4Q+/5 Gh0hBWMlHUJW4MsMW6bT8v8qw3jmDxf7UE6lrivrW/ul7zn4x8WCIW9NXB3DG70G Cf/JVHM7lcYj9S+7kxdU4v5Ct+xkOT4AUWiumVUKbO+DPdh973QoMgr1fsVGU7Nv O/ykcvJwdscGwp8eDgIWuwsFEEl1gZzBNQGZyRIBt9qt06AJmpvQ9rq0/bMA2I1L HulsIWq9QU5+ghTBuz8xcwL9Jc7NcykFWJhnBopxR+2Yr6rTjsNPv4WqzyigwakO 6+qYvCWCC+lTyZV9BkczUu9uXFHIgMxxfRKogNxRQ1ukUH/pPbJSY15f82MAmCQi MxvjnTwF8j6QSjsmwM1tfZOTEuGmVBXTTZCI2H5EFow/9FwZhSXNxa0JgqfuyXCq VClSqSS6tEdnCZS+kHVYgmzj1886iDzYJ4v+qSb0/18l677xSdVnpriFLKfLiKMH ObEUzRQlLcELOeRSjFIoS9h/Mi/1ylrlWtela95QDeXxfOiLHNCs5WWuJysWj77H oNUjkrDqoNfmpRReqKstEi3ojbsr9h7PlNwp1SR9cwLa0f8ZlLo= =4S6O -----END PGP SIGNATURE----- --Sig_/qc8uWeVfq6fCjBto+huGfjq--