From owner-cvs-all@FreeBSD.ORG  Sun Nov  4 11:44:32 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2828A16A46B;
	Sun,  4 Nov 2007 11:44:32 +0000 (UTC) (envelope-from mtm@FreeBSD.Org)
Received: from terra.mike.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id C1E7613C4A7;
	Sun,  4 Nov 2007 11:44:26 +0000 (UTC) (envelope-from mtm@FreeBSD.Org)
Received: by terra.mike.lan (Postfix, from userid 1000)
	id 16A0567878; Sun,  4 Nov 2007 14:48:12 +0300 (EAT)
From: Mike Makonnen <mtm@FreeBSD.Org>
To: Bruce Evans <brde@optusnet.com.au>
In-Reply-To: <20071031214125.V3526@delplex.bde.org>
References: <200710290008.l9T08Odw067359@repoman.freebsd.org>
	<20071030201036.GA1413@kobe.laptop>
	<20071031214125.V3526@delplex.bde.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Sun, 04 Nov 2007 14:48:11 +0300
Message-Id: <1194176891.9737.15.camel@terra>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.1 FreeBSD GNOME Team Port 
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Giorgos Keramidas <keramida@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/route route.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: mtm@FreeBSD.Org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Nov 2007 11:44:32 -0000


On Wed, 2007-10-31 at 23:41 +1100, Bruce Evans wrote:
> On Tue, 30 Oct 2007, Giorgos Keramidas wrote:
> 
> > On 2007-10-29 00:08, Mike Makonnen <mtm@freebsd.org> wrote:
> >> mtm         2007-10-29 00:08:24 UTC
> >>
> >>   FreeBSD src repository
> >>
> >>   Modified files:
> >>     sbin/route           route.c
> >>   Log:
> >>   Fix an error in bit shifting logic for network addresses. The route
> >>   command would add incorrect routing entries if network numbers weren't
> >>   fully "spelled" out according to their class. For example:
> >>     # route add 128.0/16   (works)
> >>     # route add 128/16     (doesn't work)
> 
> Isn't this supposed to be handled by inet_net_pton(3)?
> 

Yes, but the way the route(8) code is structured makes it a not minor
surgery. So, I opted for just fixing the bug than implementing it
properly.

Cheers.
-- 
Mike Makonnen         | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc
mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55
mtm @ FreeBSD.Org     | FreeBSD - http://www.freebsd.org