From owner-freebsd-commit Sat Dec 9 22:15:02 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id WAA02175 for freebsd-commit-outgoing; Sat, 9 Dec 1995 22:15:02 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id WAA02046 for cvs-all-outgoing; Sat, 9 Dec 1995 22:12:19 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id WAA02038 for cvs-sys-outgoing; Sat, 9 Dec 1995 22:12:17 -0800 (PST) Received: from jhome.DIALix.COM (jhome.DIALix.COM [192.203.228.69]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id WAA02017 Sat, 9 Dec 1995 22:12:07 -0800 (PST) Received: (from peter@localhost) by jhome.DIALix.COM (8.7.3/8.7.3) id NAA06172; Sun, 10 Dec 1995 13:37:11 +0800 (WST) Date: Sun, 10 Dec 1995 13:37:10 +0800 (WST) From: Peter Wemm To: Bruce Evans cc: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/net if_tun.c In-Reply-To: <199512100120.RAA08809@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-commit@FreeBSD.ORG Precedence: bulk On Sat, 9 Dec 1995, Bruce Evans wrote: > > bde 95/12/09 17:20:19 > > Modified: sys/net if_tun.c > Log: > Restored used variable `name[32]' (used by DEVFS). > > Removed an `#ifdef __FreeBSD__'. Hundreds, if not thousands of other > FreeBSD-specific things aren't ifdefed. I think our source could stand a lot more cleanup in this way.. After all, our sources are for FreeBSD, not GenericBSD or PortableBSD... Especially so, since we've not been consistant. I think the only real place where this kind of thing needs to stay is where we've taken 3rd party device drivers into our source that we dont maintain ourselves, and have cross-machine and version portability built in (if_cx and cx.c for example). -Peter