From owner-freebsd-stable@FreeBSD.ORG Tue Sep 13 09:46:14 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A890106566B for ; Tue, 13 Sep 2011 09:46:14 +0000 (UTC) (envelope-from longwitz@incore.de) Received: from mail.incore.de (dss.incore.de [195.145.1.138]) by mx1.freebsd.org (Postfix) with ESMTP id CCFC98FC13 for ; Tue, 13 Sep 2011 09:46:13 +0000 (UTC) Received: from inetmail.dmz (inetmail.dmz [10.3.0.3]) by mail.incore.de (Postfix) with ESMTP id 26AE95F37C; Tue, 13 Sep 2011 11:46:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at incore.de Received: from mail.incore.de ([10.3.0.3]) by inetmail.dmz (inetmail.dmz [10.3.0.3]) (amavisd-new, port 10024) with LMTP id l5oLQhzbdlRH; Tue, 13 Sep 2011 11:46:12 +0200 (CEST) Received: from mail.incore (fwintern.dmz [10.0.0.253]) by mail.incore.de (Postfix) with ESMTP id 7CCED5F344; Tue, 13 Sep 2011 11:46:12 +0200 (CEST) Received: from bsdlo.incore (bsdlo.incore [192.168.0.84]) by mail.incore (Postfix) with ESMTP id 6CA3A45088; Tue, 13 Sep 2011 11:46:12 +0200 (CEST) Message-ID: <4E6F2664.6000703@incore.de> Date: Tue, 13 Sep 2011 11:46:12 +0200 From: Andreas Longwitz User-Agent: Thunderbird 2.0.0.19 (X11/20090113) MIME-Version: 1.0 To: Adrian Chadd , freebsd-stable@freebsd.org References: <4E64933E.8030908@incore.de> <201109061104.43409.jhb@freebsd.org> <4E6D34FE.70703@incore.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: Subject: Re: UFS_DIRHASH panics on a dozen server within 30 hours X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2011 09:46:14 -0000 Hi, > You're doing a 25k allocation (why not just go with an even 32k?) but > you're not enforcing anywhere that if au_length > your #defined value, > the malloc size is made larger. > I know it's a nitpick, but if it were me doing a change, I'd use > MAX(au_length, MAX_AMR_IOCTL) when doing the malloc. Thank you for this hint, I have posted this to kern/155658. -- Dr. Andreas Longwitz Data Service GmbH Beethovenstr. 2A 23617 Stockelsdorf Amtsgericht Lübeck, HRB 318 BS Geschäftsführer: Wilfried Paepcke, Dr. Andreas Longwitz, Josef Flatau