From owner-freebsd-current@freebsd.org Wed Aug 15 03:49:10 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F3661070DDE for ; Wed, 15 Aug 2018 03:49:10 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B4A0076330 for ; Wed, 15 Aug 2018 03:49:09 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id pmmZfmzyLwyxUpmn7fYQs6; Tue, 14 Aug 2018 21:48:57 -0600 X-Authority-Analysis: v=2.3 cv=NPJhBHyg c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=dapMudl6Dx4A:10 a=vxP3BzG0AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=DxxTMZUXB4jeFQZQwtEA:9 a=CjuIK1q_8ugA:10 a=4tHceQipB5Rc01mo_vQZ:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id D0E121C0; Tue, 14 Aug 2018 20:48:04 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w7F3lfjw053615; Tue, 14 Aug 2018 20:47:41 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w7F3lfsQ053607; Tue, 14 Aug 2018 20:47:41 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201808150347.w7F3lfsQ053607@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: tech-lists cc: Cy Schubert , Shawn Webb , "Alex V. Petrov" , freebsd-current Subject: Re: zpool scrub. Wtf? In-Reply-To: Message from tech-lists of "Wed, 15 Aug 2018 04:19:21 +0100." <93818fab-6b53-bade-dffa-afcf322dce29@zyxst.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 14 Aug 2018 20:47:41 -0700 X-CMAE-Envelope: MS4wfA41vtUPh3abhMqNdzEWAnwVDLb1RO2Fo39VUEk+TXsndxUfRcLN+JQ07o7722lweHXYJx1wPuUAKjUBZgY2y+GVNat/NGTe0okEqX+dHGwvxG7J8L/s L62z9vF0zLicekqSqX9JKWxWtrA0nA5IL62arYGFqwjMi+7G8vzkeyV+M1WNtakZI26gLiJIVXb20bE/v3yzYSbItQzRtd6OqBfImd033QozO0bYGOKPQBsZ esQtsT2KH7toiL9W0dtDFsi32TP8f7DbEzzGZqJacH8= X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 03:49:10 -0000 In message <93818fab-6b53-bade-dffa-afcf322dce29@zyxst.net>, tech-lists writes: > On 12/08/2018 18:53, Cy Schubert wrote: > > I haven't looked at it closely but from what I saw it was counting scan rea > ds and issued reads. It may be a simple matter of dividing by 2. > > Dividing what by 2? > > scan: scrub in progress since Tue Aug 7 21:21:51 2018 > 804G scanned at 163M/s, 1,06T issued at 219M/s, 834G total > 0 repaired, 129,87% done, 929637 days 13:43:01 to go > > I'm also seeing this problem running 12.0-ALPHA1 #0 r337682 This is probably incorrect but this is what I was talking about. Index: cddl/contrib/opensolaris/cmd/zpool/zpool_main.c =================================================================== --- cddl/contrib/opensolaris/cmd/zpool/zpool_main.c (revision 337830) +++ cddl/contrib/opensolaris/cmd/zpool/zpool_main.c (working copy) @@ -4492,8 +4492,8 @@ scanned = ps->pss_examined; pass_scanned = ps->pss_pass_exam; - issued = ps->pss_issued; - pass_issued = ps->pss_pass_issued; + issued = ps->pss_issued / 2; + pass_issued = ps->pss_pass_issued / 2; total = ps->pss_to_examine; /* we are only done with a block once we have issued the IO for it */ -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.