Date: Tue, 14 Aug 2018 20:47:41 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: tech-lists <tech-lists@zyxst.net> Cc: Cy Schubert <Cy.Schubert@cschubert.com>, Shawn Webb <shawn.webb@hardenedbsd.org>, "Alex V. Petrov" <alexvpetrov@gmail.com>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: zpool scrub. Wtf? Message-ID: <201808150347.w7F3lfsQ053607@slippy.cwsent.com> In-Reply-To: Message from tech-lists <tech-lists@zyxst.net> of "Wed, 15 Aug 2018 04:19:21 %2B0100." <93818fab-6b53-bade-dffa-afcf322dce29@zyxst.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <93818fab-6b53-bade-dffa-afcf322dce29@zyxst.net>, tech-lists writes: > On 12/08/2018 18:53, Cy Schubert wrote: > > I haven't looked at it closely but from what I saw it was counting scan rea > ds and issued reads. It may be a simple matter of dividing by 2. > > Dividing what by 2? > > scan: scrub in progress since Tue Aug 7 21:21:51 2018 > 804G scanned at 163M/s, 1,06T issued at 219M/s, 834G total > 0 repaired, 129,87% done, 929637 days 13:43:01 to go > > I'm also seeing this problem running 12.0-ALPHA1 #0 r337682 This is probably incorrect but this is what I was talking about. Index: cddl/contrib/opensolaris/cmd/zpool/zpool_main.c =================================================================== --- cddl/contrib/opensolaris/cmd/zpool/zpool_main.c (revision 337830) +++ cddl/contrib/opensolaris/cmd/zpool/zpool_main.c (working copy) @@ -4492,8 +4492,8 @@ scanned = ps->pss_examined; pass_scanned = ps->pss_pass_exam; - issued = ps->pss_issued; - pass_issued = ps->pss_pass_issued; + issued = ps->pss_issued / 2; + pass_issued = ps->pss_pass_issued / 2; total = ps->pss_to_examine; /* we are only done with a block once we have issued the IO for it */ -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201808150347.w7F3lfsQ053607>