From owner-svn-src-all@FreeBSD.ORG Mon Oct 13 08:02:45 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9FD46C03 for ; Mon, 13 Oct 2014 08:02:45 +0000 (UTC) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com [209.85.217.180]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 23EA0EEB for ; Mon, 13 Oct 2014 08:02:44 +0000 (UTC) Received: by mail-lb0-f180.google.com with SMTP id n15so6044142lbi.11 for ; Mon, 13 Oct 2014 01:02:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=eVZtkBdsWR6mmHWOlodOa6AHioHpLkkE8o1uiArn4TA=; b=TKtNasJj4konQBimu+IEA89DLCj65rut3ZPVo9v0HklpoJwEDstr594Mp5D7tZM4sw el/1rlfExrocSXMGMQYBepuQmD8z/FVql0OfgZm+LZ+UGj3NFAsp546+0zVJC0CYbPoz FKNFd4HyLw8U6Pz++INbl/K+GTRBl9thJLKRlD2rJKd7ytnt6I7aY5vsRwkDxrpeUbSP zhwkM3kjIoJxGDjLVEx/R8TnI2ccUbe3ziZaByXwQhDB1L0lZGnf2dIGGt7M4QnUjcUq CAHZNV5xV3IvAnzdIhuLQVOCVGPnqNDHEAH5VS7P6tttBoU6yuwtUq0JzTdUF6JaItz6 htNQ== X-Gm-Message-State: ALoCoQmh+Y0Tu+Ut2/04nxNGuHSCVVJxLAJRljybcDlxJRGQL+gQ/ujp28gHcBlgIaP0zRfUsE4s X-Received: by 10.112.148.170 with SMTP id tt10mr22122944lbb.61.1413187362877; Mon, 13 Oct 2014 01:02:42 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id pd6sm4348045lbb.5.2014.10.13.01.02.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Oct 2014 01:02:42 -0700 (PDT) Message-ID: <543B8721.1050906@freebsd.org> Date: Mon, 13 Oct 2014 12:02:41 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r273024 - head/contrib/netbsd-tests/lib/libc/time References: <201410130244.s9D2iama042530@svn.freebsd.org> <543B8162.9020607@freebsd.org> In-Reply-To: <543B8162.9020607@freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2014 08:02:45 -0000 On 13.10.2014 11:38, Andrey Chernov wrote: > On 13.10.2014 6:44, Garrett Cooper wrote: >> Author: ngie >> Date: Mon Oct 13 02:44:35 2014 >> New Revision: 273024 >> URL: https://svnweb.freebsd.org/changeset/base/273024 >> >> Log: >> Only test the return value in mktime_negyear >> >> Testing for the errno is an optional requirement according to POSIX, and >> FreeBSD doesn't document that errno would be set on failure with mktime > > According to Base Specs, Issue 7, at least EOVERFLOW we don't support is > not optional. > Exact quote (I see absolutely no optionality of this): RETURN VALUE ... If the time since the Epoch cannot be represented, the function shall return the value (time_t)−1 and set errno to indicate the error. ERRORS The mktime() function shall fail if: [EOVERFLOW] The result cannot be represented. -- http://ache.vniz.net/