From owner-freebsd-gnome Mon Feb 25 0:46:23 2002 Delivered-To: freebsd-gnome@freebsd.org Received: from alcatraz.iptelecom.net.ua (alcatraz.iptelecom.net.ua [212.9.224.15]) by hub.freebsd.org (Postfix) with ESMTP id 77FEB37B402; Mon, 25 Feb 2002 00:46:17 -0800 (PST) Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by alcatraz.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id KAA96000; Mon, 25 Feb 2002 10:46:14 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from vega.vega.com (h42.228.dialup.iptcom.net [212.9.228.42]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id KAA19174; Mon, 25 Feb 2002 10:45:55 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.6/8.11.3) with ESMTP id g1P8iws22242; Mon, 25 Feb 2002 10:44:58 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3C79F9AC.C9A5088@FreeBSD.org> Date: Mon, 25 Feb 2002 10:45:32 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: obrien@FreeBSD.org Cc: gnome@FreeBSD.org Subject: Re: bsd.gnome.mk needs this patch References: <20020224222548.A66147@dragon.nuxi.com> <3C79F2DA.69EAE6A0@FreeBSD.org> <20020225002521.B29201@dragon.nuxi.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-gnome@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG David O'Brien wrote: > > On Mon, Feb 25, 2002 at 10:16:26AM +0200, Maxim Sobolev wrote: > > > Please commit ASAP. USE_MOTIF sets USE_XLIB, which then ensures the X11 > > > libs are installed. GTK(GNOME) should do the same. > > > > > > Index: bsd.gnome.mk > > > =================================================================== > > > RCS file: /home/ncvs/ports/Mk/bsd.gnome.mk,v > > > retrieving revision 1.13 > > > diff -u -r1.13 bsd.gnome.mk > > > --- bsd.gnome.mk 13 Jan 2002 12:05:07 -0000 1.13 > > > +++ bsd.gnome.mk 25 Feb 2002 06:24:39 -0000 > > > @@ -220,6 +220,7 @@ > > > .endif > > > .if defined(USE_GTK) > > > USE_GLIB= yes > > > +USE_XLIB= yes > > > .endif > > > > > > .if defined(USE_ESOUND) > > > > No, because X11 dependency inherited along with gtk+ dependency. > > To follow up, does this patch hurt anything?? Yes it doesn't, but it's pointless to insert nops here and there. > It helps solve a problem. Since you aren't the only one at gnome@, I'd > like to hear the other's opinions. Which problem? I do not see any real problem yet. Set USE_GTK in your port and do `make package-depends' - you'll see that X11 is there even without your patch. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message