Date: Mon, 26 Nov 2012 09:40:06 -0500 From: Eitan Adler <lists@eitanadler.com> To: Kevin Lo <kevlo@freebsd.org> Cc: freebsd-x11@freebsd.org Subject: Re: [PATCH] devel/gccmakede: fix build with clang Message-ID: <CAF6rxgmYZr2mgLU8GZj2ZhYAkz_DaWB9ywA9HE=KrLFMXhimOg@mail.gmail.com> In-Reply-To: <50B33B4F.9060904@FreeBSD.org> References: <50B33B4F.9060904@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 November 2012 04:50, Kevin Lo <kevlo@freebsd.org> wrote:
> Hi,
>
> Here's the diff to fix build with clang. Ok?
>
> Index: devel/gccmakedep/Makefile
> ===================================================================
> --- devel/gccmakedep/Makefile (revision 307767)
> +++ devel/gccmakedep/Makefile (working copy)
> @@ -18,4 +18,14 @@ MAN1= gccmakedep.1
>
> PLIST_FILES= bin/gccmakedep
>
> -.include <bsd.port.mk>
> +.include <bsd.port.pre.mk>
> +
> +# clang's cpp destroys whitespace, particularly hard tabs in makefiles,
> +# which is fatal for gccmakedep.
> +.if ${OSVERSION} >= 1000024 || (${OSVERSION} < 1000024 && ${CC} == "clang")
${CC} == "clang"
should be
${CC:T:M*clang*}
and the conditional on OSVERSION >= 1000024 should be contingent on ${CC}
--
Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmYZr2mgLU8GZj2ZhYAkz_DaWB9ywA9HE=KrLFMXhimOg>