From owner-freebsd-current Mon Dec 1 13:52:06 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id NAA23179 for current-outgoing; Mon, 1 Dec 1997 13:52:06 -0800 (PST) (envelope-from owner-freebsd-current) Received: from sumatra.americantv.com (sumatra.americantv.com [207.170.17.37]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id NAA23115; Mon, 1 Dec 1997 13:51:58 -0800 (PST) (envelope-from jlemon@americantv.com) Received: from right.PCS (right.PCS [148.105.10.31]) by sumatra.americantv.com (8.8.5/8.8.5) with ESMTP id PAA21554; Mon, 1 Dec 1997 15:51:48 -0600 (CST) Received: (from jlemon@localhost) by right.PCS (8.6.13/8.6.4) id PAA12719; Mon, 1 Dec 1997 15:51:17 -0600 Message-ID: <19971201155116.18825@right.PCS> Date: Mon, 1 Dec 1997 15:51:16 -0600 From: Jonathan Lemon To: Garrett Wollman Cc: John Dyson , current@freebsd.org Subject: Re: cvs commit: src/sys/kern vfs_aio.c References: <199712011841.KAA14631@freefall.freebsd.org> <199712012017.PAA01433@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.61.1 In-Reply-To: <199712012017.PAA01433@khavrinen.lcs.mit.edu>; from Garrett Wollman on Dec 12, 1997 at 03:17:41PM -0500 Sender: owner-freebsd-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Dec 12, 1997 at 03:17:41PM -0500, Garrett Wollman wrote: > < said: > > > Fix a problem when creating a new kernel thread. In some cases, aio_read > > or aio_write can return the pid of the new thread. This is due to the > > way that return values from system calls being passed by side-effect in > > the proc structure now. This commit fixes the problem with aio_read and > > aio_write. > > This is an example of why said change was a mistake... I never did get around to asking, so I guess this might be a good time as any; why were the retvals moved into the proc structure in the first place? I assume for performance reasons, but I don't recall seeing any discussion about it on the lists. -- Jonathan