From owner-freebsd-hackers Thu Nov 18 19:16:44 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from oracle.dsuper.net (oracle.dsuper.net [205.205.255.1]) by hub.freebsd.org (Postfix) with ESMTP id E3DC4155B6 for ; Thu, 18 Nov 1999 19:16:39 -0800 (PST) (envelope-from bmilekic@dsuper.net) Received: from oracle.dsuper.net (oracle.dsuper.net [205.205.255.1]) by oracle.dsuper.net (8.9.3/8.9.3) with ESMTP id WAA09726; Thu, 18 Nov 1999 22:16:37 -0500 (EST) Date: Thu, 18 Nov 1999 22:16:37 -0500 (EST) From: Bosko Milekic To: Matthew Dillon Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: mbuf wait code (revisited) -- review? In-Reply-To: <199911190102.RAA88661@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 18 Nov 1999, Matthew Dillon wrote: !> !> Sounds like a reasonable plan. I wonder if we should consider getting !> rid of the mbuf macros entirely and simply proceduralizing them. Then !> everything could be collected together into a single file. !> !> -Matt !> Matthew Dillon !> !> Well, the macros are there, as commented in uipc_mbuf.c, "for critical paths." Ultimately, having them available as macros reduces some overhead. They are also, however, available as procedures (defined in uipc_mbuf.c). The procedures actually almost act as 'wrappers' for the macros because they really just end up running these macros. On what I believe emphasis should be placed upon is making sure that ALL the code using either the macros of the procedures doesn't automatically 'assume' that they will succeed, even if the call is made with M_WAIT. If the [new] diffs that I have sitting here are committed, then that should become the focus. There still seems to be plenty of code, especially around sys/nfs that 'assumes' this 'guaranteed success,' and because of that, problems arise. Bosko. -- Bosko Milekic To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message