From owner-freebsd-testing@FreeBSD.ORG Sat Jan 25 20:36:47 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8A0A5939 for ; Sat, 25 Jan 2014 20:36:47 +0000 (UTC) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com [209.85.217.178]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 111731445 for ; Sat, 25 Jan 2014 20:36:45 +0000 (UTC) Received: by mail-lb0-f178.google.com with SMTP id u14so3410553lbd.23 for ; Sat, 25 Jan 2014 12:36:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=0sf01asixfcem68Ypwqm+ENnpWC9BjaaFhbLNWRfsF4=; b=MH0JyhOfEWwNzyBXQy4RBxnHeAtO0t3gYqiiqzA5Y0QGVYWFNJSPkDVQy4inXAfQWP KtePwFhoCNUvna77mvx5xIigG1Gx4Fy5/b10JozEllhDu/wlw8yRfwxyYBPeuZhWJdxb Nba+ihqFB5mSa38vH+8/iGgvGCeEjSOwQ6UUqsZ5iY96HrmwxHE09vz6gWfivmzicDrB u7Xla9kF7xSHiu7vJgSNdorJKlOjpWrRsNWEOBkylUhiQNCC+6pSIGuVBpW8gJOm6GzJ jrWMZkURpksEdhO+dmVJQ95nR0r7llqXZL82oRKuqtNnNO6Bu0iI4k9JCTny8dxrDqeW ROZA== X-Gm-Message-State: ALoCoQnGlm58hFvMQxjFnXufAthDWXFivdd3SQM0b8G58Xkqj9k3uiooHEflRXIj341h5yN3pVc3 X-Received: by 10.152.3.10 with SMTP id 10mr63037lay.35.1390682204036; Sat, 25 Jan 2014 12:36:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.129.101 with HTTP; Sat, 25 Jan 2014 12:36:22 -0800 (PST) X-Originating-IP: [108.176.158.82] In-Reply-To: References: <6079AD8F-5EBB-431C-A06B-9B51E2729F5A@gmail.com> From: Julio Merino Date: Sat, 25 Jan 2014 15:36:22 -0500 Message-ID: Subject: Re: [PATCH] convert bin/date over to ATF To: Garrett Cooper Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: freebsd-testing@freebsd.org, Giorgos Keramidas X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 20:36:47 -0000 On Thu, Jan 23, 2014 at 5:16 PM, Garrett Cooper wro= te: > On Jan 22, 2014, at 3:56 PM, Julio Merino wrote: > >> On Jan 20, 2014, at 13:40, Garrett Cooper wrote: >> >>> This is based on work done by Giorgos a couple years ago. >>> Thanks! >>> -Garrett >> >> Pasting patch contents and commenting inline: >> >>> diff --git a/bin/date/tests/Makefile b/bin/date/tests/Makefile >>> index 540008b..459d019 100644 >>> --- a/bin/date/tests/Makefile >>> +++ b/bin/date/tests/Makefile >>> @@ -4,6 +4,6 @@ >>> >>> TESTSDIR=3D ${TESTSBASE}/bin/date >>> >>> -TAP_TESTS_SH=3D legacy_test >>> +ATF_TESTS_SH=3D regress >> >> Tests ought to end with _test per the description in https://wiki.freebs= d.org/TestSuite/Structure > > Ok! Is `_tests` ok? _test is a very common convention "out there"; I've seen it used pretty much everywhere plus we already have a bunch of _test programs. I don't think diverging to _tests is a good idea. (The rationale for _test, I believe, is that this refers to the "test program", not its contents. But who knows -- I'm just making that up.) >> Also, "regress_test" is not a very indicative name. Will this only cont= ain test cases for bugs to prevent regressions? > > It should be =93date_functional_tests=94, because that=92s what they=92re= doing. Sure; the more descriptive, the better. (But note that this will live in a "date" subdirectory, so arguably functional_test is enough.) --=20 Julio Merino / @jmmv