From owner-svn-src-head@freebsd.org Sat Jun 16 14:57:45 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3CF671018D22; Sat, 16 Jun 2018 14:57:45 +0000 (UTC) (envelope-from lidl@pix.net) Received: from hydra.pix.net (hydra.pix.net [IPv6:2001:470:e254::4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.pix.net", Issuer "Pix.Com Technologies LLC CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E252B8419B; Sat, 16 Jun 2018 14:57:44 +0000 (UTC) (envelope-from lidl@pix.net) Received: from torb.pix.net (torb.pix.net [192.168.16.32]) (authenticated bits=0) by hydra.pix.net (8.15.2/8.15.2) with ESMTPA id w5GEvic0034848; Sat, 16 Jun 2018 10:57:44 -0400 (EDT) (envelope-from lidl@pix.net) Subject: Re: svn commit: r334947 - head/sys/modules To: Dimitry Andric , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201806110842.w5B8g4we013345@repo.freebsd.org> From: Kurt Lidl Message-ID: Date: Sat, 16 Jun 2018 10:57:44 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201806110842.w5B8g4we013345@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2018 14:57:45 -0000 On 6/11/18 4:42 AM, Dimitry Andric wrote: > Author: dim > Date: Mon Jun 11 08:42:03 2018 > New Revision: 334947 > URL: https://svnweb.freebsd.org/changeset/base/334947 > > Log: > Disable building aesni with base gcc > > Because base gcc does not support the required intrinsics, do not > attempt to compile the aesni module with it. > > Noticed by: Dan Allen > MFC after: 3 days > > Modified: > head/sys/modules/Makefile > > Modified: head/sys/modules/Makefile > ============================================================================== > --- head/sys/modules/Makefile Mon Jun 11 08:11:35 2018 (r334946) > +++ head/sys/modules/Makefile Mon Jun 11 08:42:03 2018 (r334947) > @@ -627,7 +627,9 @@ _aac= aac > _aacraid= aacraid > _acpi= acpi > .if ${MK_CRYPT} != "no" || defined(ALL_MODULES) > +.if ${COMPILER_TYPE} != "gcc" || ${COMPILER_VERSION} > 40201 > _aesni= aesni > +.endif > .endif > _amd_ecc_inject=amd_ecc_inject > _amdsbwd= amdsbwd > I thought that FreeBSD's base gcc (but not a stock 4.2.1 gcc) had support for this. As documented in UPDATING: 20130903: AES-NI intrinsic support has been added to gcc. The AES-NI module has been updated to use this support. A new gcc is required to build the aesni module on both i386 and amd64. -Kurt