Date: Tue, 9 Apr 2024 05:15:22 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Tijl Coosemans <tijl@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: cc9c37d73947 - main - */*: Always use WRK_ENV with SETENVI Message-ID: <CAMHz58TnN3k6MCJjuJggDpDrRFxdkYRG04PKZ5On-_xF87E1Ow@mail.gmail.com> In-Reply-To: <202403231747.42NHlaRh091094@gitrepo.freebsd.org> References: <202403231747.42NHlaRh091094@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000e2089706159c4f6c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Tijl, On Sun, Mar 24, 2024 at 1:47=E2=80=AFAM Tijl Coosemans <tijl@freebsd.org> w= rote: > The branch main has been updated by tijl: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Dcc9c37d73947e0184f66f0b5fa3fc= 021f7fdf51c > > commit cc9c37d73947e0184f66f0b5fa3fc021f7fdf51c > Author: Tijl Coosemans <tijl@FreeBSD.org> > AuthorDate: 2024-03-23 17:35:13 +0000 > Commit: Tijl Coosemans <tijl@FreeBSD.org> > CommitDate: 2024-03-23 17:45:45 +0000 > > */*: Always use WRK_ENV with SETENVI > > WRK_ENV contains environment variables like OSVERSION and UNAME_* tha= t > are needed when cross-building packages using Poudriere for a differe= nt > version of FreeBSD or a different architecture than that of the host > system. It's just my 2 cents. If SETENVI and WRK_ENV always come together, it would be better to have a new knob for it (e.g. SET_BASIC_ENV, SET_COMMON_ENV or SET_MIN_ENV). Therefore we won't use only part of them. The side benefit is it's shorter. Since WRK_ENV contains a minimal set of common environment variables, could we rename it to a more intuitive name such as COMMON_ENV or something like that? Regards, sunpoet --000000000000e2089706159c4f6c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello Tijl,</div><br><div class=3D"gmail_quote"><div = dir=3D"ltr" class=3D"gmail_attr">On Sun, Mar 24, 2024 at 1:47=E2=80=AFAM Ti= jl Coosemans <<a href=3D"mailto:tijl@freebsd.org" target=3D"_blank">tijl= @freebsd.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" styl= e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin= g-left:1ex">The branch main has been updated by tijl:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3Dcc9c37d73947e01= 84f66f0b5fa3fc021f7fdf51c" rel=3D"noreferrer" target=3D"_blank">https://cgi= t.FreeBSD.org/ports/commit/?id=3Dcc9c37d73947e0184f66f0b5fa3fc021f7fdf51c</= a><br> <br> commit cc9c37d73947e0184f66f0b5fa3fc021f7fdf51c<br> Author:=C2=A0 =C2=A0 =C2=A0Tijl Coosemans <tijl@FreeBSD.org><br> AuthorDate: 2024-03-23 17:35:13 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Tijl Coosemans <tijl@FreeBSD.org><br> CommitDate: 2024-03-23 17:45:45 +0000<br> <br> =C2=A0 =C2=A0 */*: Always use WRK_ENV with SETENVI<br> <br> =C2=A0 =C2=A0 WRK_ENV contains environment variables like OSVERSION and UNA= ME_* that<br> =C2=A0 =C2=A0 are needed when cross-building packages using Poudriere for a= different<br> =C2=A0 =C2=A0 version of FreeBSD or a different architecture than that of t= he host<br> =C2=A0 =C2=A0 system.</blockquote><div><br></div><div>It's just my 2 ce= nts.</div><div><br></div><div>If SETENVI and WRK_ENV always come together, = it would=C2=A0be better to have a new<br>knob for it (e.g. SET_BASIC_ENV, S= ET_COMMON_ENV or SET_MIN_ENV). Therefore we<br>won't use only part of t= hem. The side benefit is it's shorter.<br></div><div><br></div><div>Sin= ce WRK_ENV contains a minimal set of common environment variables, could we= <br>rename it to a more intuitive name such as COMMON_ENV or something like= that?<br></div><div><br></div><div>Regards,</div><div>sunpoet</div></div><= /div> --000000000000e2089706159c4f6c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58TnN3k6MCJjuJggDpDrRFxdkYRG04PKZ5On-_xF87E1Ow>