From owner-svn-src-all@FreeBSD.ORG Sat Oct 25 16:34:29 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 71FDE881; Sat, 25 Oct 2014 16:34:29 +0000 (UTC) Received: from st11p02mm-asmtp001.mac.com (st11p02mm-asmtp001.mac.com [17.172.220.236]) (using TLSv1 with cipher DES-CBC3-SHA (112/168 bits)) (Client CN "smtp.me.com", Issuer "VeriSign Class 3 Extended Validation SSL SGC CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 44081BA4; Sat, 25 Oct 2014 16:34:28 +0000 (UTC) Received: from fukuyama.hsd1.ca.comcast.net (unknown [73.162.13.215]) by st11p02mm-asmtp001.mac.com (Oracle Communications Messaging Server 7u4-27.10(7.0.4.27.9) 64bit (built Jun 6 2014)) with ESMTPSA id <0NE000MSPE17S780@st11p02mm-asmtp001.mac.com>; Sat, 25 Oct 2014 16:34:21 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52,1.0.28,0.0.0000 definitions=2014-10-25_03:2014-10-24,2014-10-25,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1408290000 definitions=main-1410250174 Content-type: text/plain; charset=us-ascii MIME-version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Subject: Re: svn commit: r273598 - in head: include sys/dev/acpica From: Rui Paulo In-reply-to: <20141025090000.GG1877@kib.kiev.ua> Date: Sat, 25 Oct 2014 09:34:18 -0700 Content-transfer-encoding: 7bit Message-id: <855B73E0-3073-407C-9A42-AEBE9B6744D6@me.com> References: <33decfcd-e77c-4e4c-8161-9f4a232213c6@me.com> <20141024194546.GE1877@kib.kiev.ua> <20141025090000.GG1877@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1990.1) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Oct 2014 16:34:29 -0000 On Oct 25, 2014, at 02:00, Konstantin Belousov wrote: > > Ok, I did looked at the pte of the HPET page. I get the value > 0x80000000fed00025 > which coincides with the resource address 0xfed00000 reported > by devinfo -vr for hpet (to double-check my findings). The low > bits indicate that PAT0 pat entry is used for the page caching > mode. Corresponding PAT MSR 0x277 has the following value: > sandy% sudo cpucontrol -m 0x277 /dev/cpuctl0 > MSR 0x277: 0x00010506 0x00070406 > i.e. memory type is 6, which is write-back, according to SDM. > This is wrong, as I feared. > > The patch below fixes the issue. The pte for HPET page is equal to > 0x80000000fed0003d > after the patch is applied, PAT3 is used, and its value is 0 == > UNCACHEABLE, as it must be. > > Do you agree with the patch ? Yes, thanks for working on this! -- Rui Paulo