Date: Sat, 11 Nov 2006 14:41:06 -0500 From: Kris Kennaway <kris@obsecurity.org> To: Rong-En Fan <rafan@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/chinese/big5width Makefile Message-ID: <20061111194106.GA8467@xor.obsecurity.org> In-Reply-To: <20061111185430.GG20014@svm.csie.ntu.edu.tw> References: <200611111844.kABIiIUY022772@repoman.freebsd.org> <20061111184817.GA7300@xor.obsecurity.org> <20061111185430.GG20014@svm.csie.ntu.edu.tw>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sun, Nov 12, 2006 at 02:54:30AM +0800, Rong-En Fan wrote:
> > > | PORTNAME= big5width
> > > | @@ -48,8 +48,10 @@ do-install:
> > > | ${INSTALL_DATA} ${WRKSRC}/LC_CTYPE ${LOCALEDIR}/${LANG}
> > > | ${CP} -p ${BASELOCALEDIR}/${LANG}/LC_CTYPE \
> > > | ${LOCALEDIR}/${LANG}/LC_CTYPE.old
> > > | +.if !defined(PACKAGE_BUILDING) # don't modify building environment
> > > | ${LN} -sf ${LOCALEDIR}/${LANG}/LC_CTYPE \
> > > | ${BASELOCALEDIR}/${LANG}/LC_CTYPE
> > > | +.endif
> >
> > I'd prefer not to hack around the issue by just hiding it from view.
> > The package should put things back the way they were when
> > deinstalling, to not leave the user system in a dirty state.
>
> I thought the line in pkg-plist
>
> @unexec rm -f %%BASELOCALEDIR%%/%%LANG%%/LC_CTYPE; mv -f %D/share/locale/%%LANG%%/LC_CTYPE.old %%%BASELOCALEDIR%%/%%LANG%%/LC_CTYPE
>
> should do the trick.
>
> The build error is due to /usr/share/locale/zh_TW.UTF-8/LC_CTYPE is a
> link, when mtree expects to see a file. OK, I can make it a file, and
> put back the old one when deinstall. Does this approach sound ok for
> you?
Actually the other way around: it used to be a link (so it expects it
to still be a link), and now it's a file. This is what I mean by
putting things back the way they were.
Kris
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)
iD8DBQFFVidSWry0BWjoQKURAmIXAKDvgMpy/unsu385sOfC27ADhQh86QCgv6DL
eG2iUvw3siBTT18cmdojiJM=
=6UHy
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061111194106.GA8467>