Date: Thu, 22 Mar 2012 19:28:16 +0100 From: Bernhard Schmidt <bschmidt@freebsd.org> To: freebsd-net@freebsd.org Cc: Monthadar Al Jaberi <monthadar@gmail.com> Subject: Re: ifconfig meshforward command bug Message-ID: <201203221928.16271.bschmidt@freebsd.org> In-Reply-To: <CA%2BsBSoJaxxRRsUqmpN6k8q6M_SZ_605ip6auN44k5BQ7a_XOtQ@mail.gmail.com> References: <CA%2BsBSoJaxxRRsUqmpN6k8q6M_SZ_605ip6auN44k5BQ7a_XOtQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 22 March 2012 16:59:44 Monthadar Al Jaberi wrote:
> Hi,
>
> I think this is a bug in ifconfig, sending val to kernel always
> results in zero. There are a couple of these, just want to hear from
> you guys if you think this is a bug too.
>
> --- a/sbin/ifconfig/ifieee80211.c
> +++ b/sbin/ifconfig/ifieee80211.c
> @@ -1879,13 +1879,19 @@ DECL_CMD_FUNC(set80211meshttl, val, d)
> static
> DECL_CMD_FUNC(set80211meshforward, val, d)
> {
> - set80211(s, IEEE80211_IOC_MESH_FWRD, atoi(val), 0, NULL);
> + set80211(s, IEEE80211_IOC_MESH_FWRD, d, 0, NULL);
Seems about right, those declared with DEF_CMD() should use d.
--
Bernhard
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203221928.16271.bschmidt>