From owner-freebsd-stable@FreeBSD.ORG Mon Jan 5 20:24:17 2015 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8293BD04 for ; Mon, 5 Jan 2015 20:24:17 +0000 (UTC) Received: from isis.morrow.me.uk (isis.morrow.me.uk [204.109.63.142]) by mx1.freebsd.org (Postfix) with ESMTP id 5B4E03628 for ; Mon, 5 Jan 2015 20:24:17 +0000 (UTC) Received: from anubis.morrow.me.uk (unknown [93.89.81.46]) (Authenticated sender: mauzo) by isis.morrow.me.uk (Postfix) with ESMTPSA id B02FD45087; Mon, 5 Jan 2015 20:17:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.8.3 isis.morrow.me.uk B02FD45087 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=morrow.me.uk; s=dkim201101; t=1420489078; bh=zkcc0xbaM7LRkY3RD4sKYJk46zQZXbs59NW7xviuAHE=; h=Date:From:To:Subject:References:In-Reply-To; b=gNLqIbI1iGohAvoSYY8XALCrWnRykr3Z8tRxdFkQwFwKPIU39Q6reANSPL51TByKv nPIUkNyD9AT590c14OD1dToSpl6ngRIURohuN5cUiIoQH6Y0flMGAuJnVv0TSe3JHM HF4hNS013sa6pVxUsoaQa6zQ542ZRJJeMmeCfe/g= X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.98.4 at isis.morrow.me.uk Received: by anubis.morrow.me.uk (Postfix, from userid 5001) id 42A2F160AB; Mon, 5 Jan 2015 20:17:51 +0000 (GMT) Date: Mon, 5 Jan 2015 20:17:50 +0000 From: Ben Morrow To: rkoberman@gmail.com, freebsd-stable@freebsd.org Subject: Re: Upgrading from stable/8 to stable/9 blocked by file 5.21 (r276416) Message-ID: <20150105201735.GA2642@anubis.morrow.me.uk> Mail-Followup-To: rkoberman@gmail.com, freebsd-stable@freebsd.org References: <54A9A853.2000208@delphij.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Newsgroups: gmane.os.freebsd.stable User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 20:24:17 -0000 Quoth Kevin Oberman : > On Mon, Jan 5, 2015 at 1:49 AM, Trond Endrestøl < > Trond.Endrestol@fagskolen.gjovik.no> wrote: > > > ===> lib/libmagic (obj,build-tools) > > gcc -O2 -pipe -DMAGIC='"/usr/share/misc/magic"' -DHAVE_CONFIG_H > > -I/usr/src/lib/libmagic -I/usr/src/lib/libmagic/../../contrib/file/src > > -std=gnu99 -I/usr/obj/usr/src/tmp/legacy/usr/include -DCOMPILE_ONLY > > -L/usr/obj/usr/src/tmp/legacy/usr/lib -o mkmagic [...] > > This still comes down to he build of file (and specifically libmagick not > finding xlocale.h. the new header files should have been installed into > /usr/obj long before the build of file starts. the buildworld should always > run clean, obj, _includes, and depends before any of the actual builds > commence. > > So the issue is whether the build of libmagic is failing to look for > xlocale.h in the right place or the _includes: target is failing to install > it there. > > This can be checked by building without -j (to eliminate any possible > races) and, after the failure, look for xlocale.h in > /usr/obj/usr/src/tmp/usr/include. This is where all header files should be > installed in the /usr/obj tree so that they are available and used by the > buildworld. If I'm reading Makefile.inc1 right (and it's possible I'm not) then the build-tools stage comes before the compiler is rebuilt, so it's still using the host system compiler. If I'm right about that, then that gcc command above isn't looking in that directory (it's looking in /legacy/ instead, which doesn't get xlocale.h). Also, unless I'm mistaken, the _includes stage ('stage 4.1: building includes') runs after the build-tools stage ('stage 2.3: build tools'). The only headers that have been installed by that point are those installed in .../tmp/legacy/usr/include by 'legacy' and 'bootstrap-tools'. Ben