From owner-freebsd-bugs@FreeBSD.ORG  Sun May 30 13:30:25 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F041A16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 30 May 2004 13:30:25 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CD32943D48
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 30 May 2004 13:30:25 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i4UKUPcq065972	for <freebsd-bugs@freefall.freebsd.org>;
	Sun, 30 May 2004 13:30:25 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4UKUP8c065968;
	Sun, 30 May 2004 13:30:25 -0700 (PDT)
	(envelope-from gnats)
Resent-Date: Sun, 30 May 2004 13:30:25 -0700 (PDT)
Resent-Message-Id: <200405302030.i4UKUP8c065968@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Matthew Emmerton <matt@gsicomp.on.ca>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B2CB416A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 30 May 2004 13:29:15 -0700 (PDT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AC6A243D5D
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 30 May 2004 13:29:15 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i4UKTFmP010073
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 30 May 2004 13:29:15 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i4UKTFiE010072;
	Sun, 30 May 2004 13:29:15 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200405302029.i4UKTFiE010072@www.freebsd.org>
Date: Sun, 30 May 2004 13:29:15 -0700 (PDT)
From: Matthew Emmerton <matt@gsicomp.on.ca>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: bin/67392: Small memory leak in ls
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 May 2004 20:30:26 -0000


>Number:         67392
>Category:       bin
>Synopsis:       Small memory leak in ls
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 30 13:30:25 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Matthew Emmerton
>Release:        4.9-STABLE
>Organization:
GSI Computer Service
>Environment:
FreeBSD penelope.gsicomp.on.ca 4.9-STABLE FreeBSD 4.9-STABLE #3: Fri May  7 22:16:53 EDT 2004     root@penelope.gsicomp.on.ca:/usr/obj/usr/src/sys/PENELOPE.20040505.01  i386
      
>Description:
There is a tiny memory leak in 'ls'.

If the LS_COLWIDTHS environment variable is defined, then a small memory buffer is malloc()'d to build up a temporary string which is then passed to sscanf().

However, this memory buffer is never freed.
>How-To-Repeat:
I haven't been able to find a test case that causes the memory leak to impact the system.

>Fix:
--- bin/ls/ls.c.orig    Sun May 30 16:34:54 2004
+++ bin/ls/ls.c Sun May 30 16:35:06 2004
@@ -597,6 +597,7 @@
                maxblock = makenines(maxblock);
                maxnlink = makenines(maxnlink);
                maxsize = makenines(maxsize);
+               free(jinitmax);
        }
        bcfile = 0;
        flags = NULL;

>Release-Note:
>Audit-Trail:
>Unformatted: