From owner-freebsd-bugs@freebsd.org  Fri Jul 29 21:57:38 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF193BA8689
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Fri, 29 Jul 2016 21:57:38 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9ED981C4B
 for <freebsd-bugs@FreeBSD.org>; Fri, 29 Jul 2016 21:57:38 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6TLvcPe027795
 for <freebsd-bugs@FreeBSD.org>; Fri, 29 Jul 2016 21:57:38 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 211448] sysrc(8): exit status on permission error
Date: Fri, 29 Jul 2016 21:57:38 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: easy, needs-patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: me@cschwarz.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status keywords bug_severity priority component assigned_to
 reporter
Message-ID: <bug-211448-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jul 2016 21:57:38 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211448

            Bug ID: 211448
           Summary: sysrc(8): exit status on permission error
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Keywords: easy, needs-patch
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: me@cschwarz.com

When sysrc(8) encounters a permission error when changing a variable, it pr=
ints
an error message to stderr but exits with status 0.

This behavior is especially annoying in automation tools, as I had to encou=
nter
recently (https://github.com/ansible/ansible-modules-core/pull/4283):

An unprivileged user will have to use heuristics and not rely on the exit
status being !=3D 0 to check if the sysrc(8) call succeeded.

Steps to reproduce:

 Login as unprivileged user.
 Run `sysrc sshd_enable=3DNO`.
 =3D> Exit code =3D 0
 =3D> Stderr: `sysrc: cannot create /etc/rc.conf: Permission denied\n`
 =3D> Stdour: <empty>

Expected:

 Exit code =3D 1

--=20
You are receiving this mail because:
You are the assignee for the bug.=