From owner-freebsd-hackers@freebsd.org Sat Jun 2 00:07:47 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF16BEFF336 for ; Sat, 2 Jun 2018 00:07:47 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3FBAF7DFC3 for ; Sat, 2 Jun 2018 00:07:47 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 242E21E63F for ; Sat, 2 Jun 2018 00:07:46 +0000 (UTC) Subject: Re: PRs are being closed for bogus reasons :-( To: freebsd-hackers@freebsd.org References: <1407.1527801278@critter.freebsd.dk> From: Allan Jude Openpgp: preference=signencrypt Autocrypt: addr=allanjude@freebsd.org; prefer-encrypt=mutual; keydata= xsFNBFVwZcYBEADwrZDH0xe0ZVjc9ORCc6PcBLwS/RTXA6NkvpD6ea02pZ8lPOVgteuuugFc D34LdDbiWr+479vfrKBh+Y38GL0oZ0/13j10tIlDMHSa5BU0y6ACtnhupFvVlQ57+XaJAb/q 7qkfSiuxVwQ3FY3PL3cl1RrIP5eGHLA9hu4eVbu+FOX/q/XVKz49HaeIaxzo2Q54572VzIo6 C28McX9m65UL5fXMUGJDDLCItLmehZlHsQQ+uBxvODLFpVV2lUgDR/0rDa0B9zHZX8jY8qQ7 ZdCSy7CwClXI054CkXZCaBzgxYh/CotdI8ezmaw7NLs5vWNTxaDEFXaFMQtMVhvqQBpHkfOD 7rjjOmFw00nJL4FuPE5Yut0CPyx8vLjVmNJSt/Y8WxxmhutsqJYFgYfWl/vaWkrFLur/Zcmz IklwLw35HLsCZytCN5A3rGKdRbQjD6QPXOTJu0JPrJF6t2xFkWAT7oxnSV0ELhl2g+JfMMz2 Z1PDmS3NRnyEdqEm7NoRGXJJ7bgxDbN+9SXTyOletqGNXj/bSrBvhvZ0RQrzdHAPwQUfVSU2 qBhQEi2apSZstgVNMan0GUPqCdbE2zpysg+zT7Yhvf9EUQbzPL4LpdK1llT9fZbrdMzEXvEF oSvwJFdV3sqKmZc7b+E3PuxK6GTsKqaukd/3Cj8aLHG1T1im1QARAQABzSJBbGxhbiBKdWRl IDxhbGxhbmp1ZGVAZnJlZWJzZC5vcmc+wsF/BBMBAgApBQJVcGXGAhsjBQkSzAMABwsJCAcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQGZU1PhKYC34Muw/+JOKpSfhhysWFYiRXynGRDe07 Z6pVsn7DzrPUMRNZfHu8Uujmmy3p2nx9FelIY9yjd2UKHhug+whM54MiIFs90eCRVa4XEsPR 4FFAm0DAWrrb7qhZFcE/GhHdRWpZ341WAElWf6Puj2devtRjfYbikvj5+1V1QmDbju7cEw5D mEET44pTuD2VMRJpu2yZZzkM0i+wKFuPxlhqreufA1VNkZXI/rIfkYWK+nkXd9Efw3YdCyCQ zUgTUCb88ttSqcyhik/li1CDbXBpkzDCKI6I/8fAb7jjOC9LAtrZJrdgONywcVFoyK9ZN7EN AVA+xvYCmuYhR/3zHWH1g4hAm1v1+gIsufhajhfo8/wY1SetlzPaYkSkVQLqD8T6zZyhf+AN bC7ci44UsiKGAplB3phAXrtSPUEqM86kbnHg3fSx37kWKUiYNOnx4AC2VXvEiKsOBlpyt3dw WQbOtOYM+vkfbBwDtoGOOPYAKxc4LOIt9r+J8aD+gTooi9Eo5tvphATf9WkCpl9+aaGbSixB tUpvQMRnSMqTqq4Z7DeiG6VMRQIjsXDSLJEUqcfhnLFo0Ko/RiaHd5xyAQ4DhQ9QpkyQjjNf /3f/dYG7JAtoD30txaQ5V8uHrz210/77DRRX+HJjEj6xCxWUGvQgvEZf5XXyxeePvqZ+zQyT DX61bYw6w6bOwU0EVXBlxgEQAMy7YVnCCLN4oAOBVLZ5nUbVPvpUhsdA94/0/P+uqCIh28Cz ar56OCX0X19N/nAWecxL4H32zFbIRyDB2V/MEh4p9Qvyu/j4i1r3Ex5GhOT2hnit43Ng46z5 29Es4TijrHJP4/l/rB2VOqMKBS7Cq8zk1cWqaI9XZ59imxDNjtLLPPM+zQ1yE3OAMb475QwN UgWxTMw8rkA7CEaqeIn4sqpTSD5C7kT1Bh26+rbgJDZ77D6Uv1LaCZZOaW52okW3bFbdozV8 yM2u+xz2Qs8bHz67p+s+BlygryiOyYytpkiK6Iy4N7FTolyj5EIwCuqzfk0SaRHeOKX2ZRjC qatkgoD/t13PNT38V9tw3qZVOJDS0W6WM8VSg+F+bkM9LgJ8CmKV+Hj0k3pfGfYPOZJ/v18i +SmZmL/Uw2RghnwDWGAsPCKu4uZR777iw7n9Io6Vfxndw2dcS0e9klvFYoaGS6H2F13Asygr WBzFNGFQscN4mUW+ZYBzpTOcHkdT7w8WS55BmXYLna+dYer9/HaAuUrONjujukN4SPS1fMJ2 /CS/idAUKyyVVX5vozoNK2JVC1h1zUAVsdnmhEzNPsvBoqcVNfyqBFROEVLIPwq+lQMGNVjH ekLTKRWf59MEhUC2ztjSKkGmwdg73d6xSXMuq45EgIJV2wPvOgWQonoHH/kxABEBAAHCwWUE GAECAA8FAlVwZcYCGwwFCRLMAwAACgkQGZU1PhKYC34w5A//YViBtZyDV5O+SJT9FFO3lb9x Zdxf0trA3ooCt7gdBkdnBM6T5EmjgVZ3KYYyFfwXZVkteuCCycMF/zVw5eE9FL1+zz9gg663 nY9q2F77TZTKXVWOLlOV2bY+xaK94U4ytogOGhh9b4UnQ/Ct3+6aviCF78Go608BXbmF/GVT 7uhddemk7ItxM1gE5Hscx3saxGKlayaOsdPKeGTVJCDEtHDuOc7/+jGh5Zxpk/Hpi+DUt1ot 8e6hPYLIQa4uVx4f1xxxV858PQ7QysSLr9pTV7FAQ18JclCaMc7JWIa3homZQL/MNKOfST0S 2e+msuRwQo7AnnfFKBUtb02KwpA4GhWryhkjUh/kbVc1wmGxaU3DgXYQ5GV5+Zf4kk/wqr/7 KG0dkTz6NLCVLyDlmAzuFhf66DJ3zzz4yIo3pbDYi3HB/BwJXVSKB3Ko0oUo+6/qMrOIS02L s++QE/z7K12CCcs7WwOjfCYHK7VtE0Sr/PfybBdTbuDncOuAyAIeIKxdI2nmQHzl035hhvQX s4CSghsP319jAOQiIolCeSbTMD4QWMK8RL/Pe1FI1jC3Nw9s+jq8Dudtbcj2UwAP/STUEbJ9 5rznzuuhPjE0e++EU/RpWmcaIMK/z1zZDMN+ce2v1qzgV936ZhJ3iaVzyqbEE81gDxg3P+IM kiYh4ZtPB4Q= Message-ID: <1e0e3db1-f1d6-b225-df3e-182c0ed71818@freebsd.org> Date: Fri, 1 Jun 2018 20:07:43 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TT1I4uakRtLBT0fAdgg6wgJKjxiH7LCsH" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jun 2018 00:07:48 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TT1I4uakRtLBT0fAdgg6wgJKjxiH7LCsH Content-Type: multipart/mixed; boundary="Rl5PYaMOEqQ1WgxhNtmAK3BaQQSapgfyC"; protected-headers="v1" From: Allan Jude To: freebsd-hackers@freebsd.org Message-ID: <1e0e3db1-f1d6-b225-df3e-182c0ed71818@freebsd.org> Subject: Re: PRs are being closed for bogus reasons :-( References: <1407.1527801278@critter.freebsd.dk> In-Reply-To: --Rl5PYaMOEqQ1WgxhNtmAK3BaQQSapgfyC Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-06-01 11:27, Kristof Provost wrote: > On 1 Jun 2018, at 17:09, Warner Losh wrote: >> On Fri, Jun 1, 2018 at 8:53 AM, wrote: >>>> On 1 Jun 2018, at 15:41, Warner Losh wrote: >>> The sad truth is that only about 10-15% of them have comitable >>> patches in >>> them when submitted. And that number decays over time as things age i= n >>> bugzilla. [etc] >>> >>> Sure. But the best a non-comitter can do is to supply a patch tested >>> against HEAD. If the patch rots because it hasn=E2=80=99t been commit= ted six >>> months >>> down the line it=E2=80=99s not my fault. >>> >> >> Well, not quite true. I've had several people send me pointers to bugs= >> over >> the years and engage me when I tell them that the patch isn't quite >> right. >> That conversation is easier, to my mind, in Phabricator, though. >> There's no >> substitute for making good connections and motivating volunteers to >> want to >> help you. That gives much better results than filing and forgetting an= d >> hoping for the best. As a committer, I find it a low return on investm= ent >> to go looking at random PRs. I find it a much higher return on investm= ent >> when I have a history with someone (even a short one). >> >> Fixing this broken state of affairs is not going to be easy... >> > This is also true for bug reports with no patches attached to them. > Bug reports with more information, more reports from people affected by= the > same bug, simplified test cases, follow-up with confirmation that other= > versions are affected too and so on are more likely to attract attentio= n. >=20 > For better or worse, the fact is that both patches and bug reports fare= > better > if their submitter actively advocates for them. >=20 > I don=E2=80=99t mean to suggest that it is somehow the fault of the sub= mitter if > bugs > don=E2=80=99t get fixed. Instead I want to point at this as something p= eople can > do to > help, even if they don=E2=80=99t have commit access, or even if they do= n't know > how to > read or write code. >=20 > Regards, > Kristof > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.o= rg" This point was well made by one of Ed Maste's interns for the spring semester. A good glimpse into the 'new contributor' experience: https://www.freebsdfoundation.org/blog/guest-blog-what-i-learned-during-m= y-freebsd-internship/ --=20 Allan Jude --Rl5PYaMOEqQ1WgxhNtmAK3BaQQSapgfyC-- --TT1I4uakRtLBT0fAdgg6wgJKjxiH7LCsH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJbEd/SAAoJEBmVNT4SmAt+0I4QAI5X1eguhlwDR4U4/ua2Y6oQ hf1WYAYL/jsORd/kh2XkRW+UlogTI/XeKbjN5ZmwK2IYepcnB/wqfU6kyuQSloHX t4ktIJQS4iXVsLN4NS11uWhOSqAw6cGfznncZHTQaYS5Sc7dBQmUuH4aVqXpYepW Ql1N6ZLuRQCuaxoVwOdqwzdEitzwEcf0rDBsvgfDjdytoVEWR33euVTxo2f3ypoq kV5br0rcA4lCfl3NkcA0rLcsnDm4/6rBwqfbFQg5+LFZ+teLgvxEeILUD59qWL63 HRiCvb2c5LCpvwMVPhYmgTFeu19K6yCjHnxWt9hVP3Tb4eu34qVMFOmtA+x7y6BZ zY61x79qTJ91wmrKvgtaAO1F4+XSzFHCny4P3sXZmChiWDp5hxnfMFu1pumtss8K tV7B/o0KPl6tre0ISpYZnRCB9beJiBH0EWwXWhz7r8KlM0DzQEZ5Y78xNmJ9x1kW UsJ+iu8obbjyn3MaxHE2LWkadv6I5BppB69EBP63ZHUtFogrz9Fb3++8Aew/6tpV 6BxCqSklnYR8EEp2kBBacS9vge0Y05+aXD09nu5U+dS/+WBZt7zTD/dMTriTXSE8 SdmoNLmnkANeHZ6bQnv58oxgmvbepxPur/733AyY1C45B8PdFE6SF6Wcl8l+x2S9 YV2LSb9AK4cuvylkNUPV =lGOw -----END PGP SIGNATURE----- --TT1I4uakRtLBT0fAdgg6wgJKjxiH7LCsH--