Date: Wed, 1 Mar 2023 10:36:18 +0100 From: Florian Smeets <flo@smeets.xyz> To: Guido Falsi <madpilot@freebsd.org> Cc: Robert Clausecker <fuz@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 47912ce2e613 - main - databases/sqlite3: update to 3.41.0 Message-ID: <Y/8ckrjpK0us26ka@mail.smeets.xyz> In-Reply-To: <240c5332-fb8b-0162-2a53-c73c6b9ab1f8@FreeBSD.org> References: <202302272249.31RMnYh9078107@gitrepo.freebsd.org> <240c5332-fb8b-0162-2a53-c73c6b9ab1f8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ebPifDJHAtt3Ga8D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2023 at 11:40:13PM +0100, Guido Falsi wrote: > On 27/02/23 23:49, Robert Clausecker wrote: > > The branch main has been updated by fuz: > >=20 > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D47912ce2e613211aecf6ec= dfc58681b7aca0df33 > >=20 > > commit 47912ce2e613211aecf6ecdfc58681b7aca0df33 > > Author: Pavel Volkov <pavelivolkov@gmail.com> > > AuthorDate: 2023-02-24 09:23:48 +0000 > > Commit: Robert Clausecker <fuz@FreeBSD.org> > > CommitDate: 2023-02-27 22:46:24 +0000 > >=20 > > databases/sqlite3: update to 3.41.0 > > =20 > > Disable option DQS by default. > > Add a note to UPDATING about this. > > =20 >=20 I'm answering as I'm the one that approved the commit. > While I understand your motives this is a dangerous choice. There will=20 > be a lot of runtime breakage in ports using sqlite3. We are following upstream on this one, it's in the release notes. https://www.sqlite.org/releaselog/3_41_0.html 6.f. The double-quoted string misfeature is now disabled by default for CLI builds. Legacy use cases can reenable the misfeature at run-time using the ".dbconfig dqs_dml on" and ".dbconfig dqs_ddl on" commands.=20 Accoring to https://www.sqlite.org/quirks.html#dblquote there has been a warning for 4 years warning about use of double quoted strings. >=20 > I just discovered that deskutils/calibre in some parts of the code falls= =20 > for this. >=20 > This is relatively easy to fix and I am testing patches. I'll also=20 > submit it upstream: >=20 > https://github.com/madpilot78/calibre/commit/e79cfdd3c6ab232fefa78dc18526= 1ced7a209ae7 >=20 > but I'm sure a lot of ports will start acting up for no apparent reason= =20 > due to this. Can someone back this up with some numbers? If I underestimated the consequences and this does indeed break more stuff we can/should revert, but we would deviate from upstream. I see we have a PR with at least two more broken ports 269889. Florian --ebPifDJHAtt3Ga8D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7LNouHkIv7aRTXJp71uk3NWp88AFAmP/HJJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVD QjM2OEI4NzkwOEJGQjY5MTRENzI2OUVGNUJBNERDRDVBOUYzQzAACgkQ71uk3NWp 88C8aA/+MLc3GwfYnM4NxIj6HhBtQ9U83kt2GHZDlceX9nlveZwbIg5UgOcT8Ohi DzJg1Xsaum0FdKFJsm+jmSf8sZcwGkZIt2dOrrA+EirHGhv3R2QIS8PzpMq40ZDa LH1txi0aRT2tmA+E65g1uVTSCdPKPDMopT24l/kkqfNHufcm8XDijHUzMF2H7uCq 8U7QgM1V9GvGivWfgD+7/D/7SExTR3wV2PvGKNXIk4YqXJmbhECZ6uwr1Rkr8lVH viqfB23UfkvHsg139ze/jY4qY+9FL8DOLGoeFtGmIm/21H7jK19tceOCI2UGya0j 9wGmRYw4tkSR3oGN1H5nlBWMuj+/HNHe4SZLXH88/QX7RR55UZsmtDFFqquD1oaw Xl1GCZ5gCLWstDV9Djj+p7ElzuQAKMREpIcXlByMb7wjsbb5hbYW5A7dAw+74yHg TeFKHjYZnni3jMrIkSA1ZuicvvA2k0Ujak9eJhTSdZi6DeXn+Sh95wsVLCnCFYYF TZ3nHSgFkCIQfMrhxCctDv41cO1dp8jLxjzUzbMtkfL6zr0MdN7k/Py+/QL0EhyQ 3HXicprGyeLaavmwoRUC8Uf/CmddrzEtYOLdPcdbtWeH/FLNgRVVw4bzFHIC0SX1 DaeJOIcE973+8YTfi0osH48pNnRkNSf8Ayc28tULYn3k7Y2upoo= =3X/C -----END PGP SIGNATURE----- --ebPifDJHAtt3Ga8D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y/8ckrjpK0us26ka>