From owner-freebsd-commit Wed Oct 25 12:13:20 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA06445 for freebsd-commit-outgoing; Wed, 25 Oct 1995 12:13:20 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA06431 for cvs-all-outgoing; Wed, 25 Oct 1995 12:13:17 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA06418 for cvs-sys-outgoing; Wed, 25 Oct 1995 12:13:15 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id MAA06411 ; Wed, 25 Oct 1995 12:13:08 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id FAA17483; Thu, 26 Oct 1995 05:11:25 +1000 Date: Thu, 26 Oct 1995 05:11:25 +1000 From: Bruce Evans Message-Id: <199510251911.FAA17483@godzilla.zeta.org.au> To: CVS-commiters@freefall.freebsd.org, bde@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern tty_pty.c Sender: owner-commit@FreeBSD.org Precedence: bulk > Modified: sys/kern tty_pty.c > Log: > Fixed data loss in writes to pty masters. Data was almost always lost > at the end of each write for writes of more than 1K. > > Fixed handling of residual count for early returns in writes to pty masters. > It was only adjusted in 2 out of 6 cases. These changes should be in 2.1 too. Sigh. They should be checked more carefully than the changes in tty_subr.c. I'm not sure what happens in the PF_REMOTE case. cc can only be 0 in that case if the PF_REMOTE flag changed. If that can happen, then cc may be too large to fit in the canq and not everything is written. Bruce