Date: Mon, 10 Jan 2022 11:37:13 -0800 From: Ultima <ultima@ultimasbox.com> To: Rene Ladan <rene@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9f1b1be53d96 - main - *: Updated guacamole-[server|client] to 1.4.0 Message-ID: <CANJ8om5qmNAWF7xtL%2Bafs80K5RoQi%2B_uq4%2B8TkY3NAAm2yTdGg@mail.gmail.com> In-Reply-To: <YdxchP0eBaLe2KTI@freefall.freebsd.org> References: <202201092309.209N9lFf039776@gitrepo.freebsd.org> <YduWxlKfqjJPRfTm@FreeBSD.org> <Ydvr85vbKEsP5gKi@freefall.freebsd.org> <Ydv51Io7dK0Vx1Bb@FreeBSD.org> <YdxchP0eBaLe2KTI@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000004a43c305d53f7794 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yeah someone complained about how I was formatting it a couple of months back. Will follow the "topic: action" format as would be more appropriate than asterisk. The 72 character limit is very limiting thought. Best regards, Richard Gallamore On Mon, Jan 10, 2022 at 8:19 AM Rene Ladan <rene@freebsd.org> wrote: > On Mon, Jan 10, 2022 at 09:18:12AM +0000, Alexey Dokuchaev wrote: > > On Mon, Jan 10, 2022 at 08:18:59AM +0000, Rene Ladan wrote: > > > On Mon, Jan 10, 2022 at 02:15:34AM +0000, Alexey Dokuchaev wrote: > > > > On Sun, Jan 09, 2022 at 11:09:47PM +0000, Richard Gallamore wrote: > > > > > commit 9f1b1be53d965ca9eedef7a6547eb47973c8dae0 > > > > > > > > > > *: Updated guacamole-[server|client] to 1.4.0 > > > > > > > > There's no need to mutilate commit logs with `*:' anymore, JFYI. > > > > > > Talking about mutilating commit logs, how about using the contents > > > of COMMENT as the first line of the commit log of newly added ports > > > instead of a non-informative "new port has been added (+)" ? > > > > This is not mutilation: this won't work as COMMENT alone does not > > constitute *action* inflicted on the port, and amending the COMMENT > > with extra text to make it suitable for action won't fit the line > > limit, which is even less than common ~72 characters due to stupid > > four-characted padding git puts in front of the log. > > > Having a short description of what the port does is more useful > than forcing the git summary in an active tense. > > Ren=C3=A9 > --0000000000004a43c305d53f7794 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Yeah someone complained about how I was formatting it= a couple</div><div>of months back. Will follow the "topic: action&quo= t; format as would be</div><div>more appropriate than asterisk. The 72 char= acter limit is very limiting</div><div>thought.<br></div><div><br></div><di= v>Best regards,</div><div>Richard Gallamore<br></div></div><br><div class= =3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 10, 2022= at 8:19 AM Rene Ladan <<a href=3D"mailto:rene@freebsd.org">rene@freebsd= .org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar= gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1= ex">On Mon, Jan 10, 2022 at 09:18:12AM +0000, Alexey Dokuchaev wrote:<br> > On Mon, Jan 10, 2022 at 08:18:59AM +0000, Rene Ladan wrote:<br> > > On Mon, Jan 10, 2022 at 02:15:34AM +0000, Alexey Dokuchaev wrote:= <br> > > > On Sun, Jan 09, 2022 at 11:09:47PM +0000, Richard Gallamore = wrote:<br> > > > > commit 9f1b1be53d965ca9eedef7a6547eb47973c8dae0<br> > > > > <br> > > > >=C2=A0 =C2=A0 =C2=A0*: Updated guacamole-[server|client]= to 1.4.0<br> > > > <br> > > > There's no need to mutilate commit logs with `*:' an= ymore, JFYI.<br> > > <br> > > Talking about mutilating commit logs, how about using the content= s<br> > > of COMMENT as the first line of the commit log of newly added por= ts<br> > > instead of a non-informative "new port has been added (+)&qu= ot; ?<br> > <br> > This is not mutilation: this won't work as COMMENT alone does not<= br> > constitute *action* inflicted on the port, and amending the COMMENT<br= > > with extra text to make it suitable for action won't fit the line<= br> > limit, which is even less than common ~72 characters due to stupid<br> > four-characted padding git puts in front of the log.<br> > <br> Having a short description of what the port does is more useful<br> than forcing the git summary in an active tense.<br> <br> Ren=C3=A9<br> </blockquote></div> --0000000000004a43c305d53f7794--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANJ8om5qmNAWF7xtL%2Bafs80K5RoQi%2B_uq4%2B8TkY3NAAm2yTdGg>