From owner-freebsd-hackers@FreeBSD.ORG Wed Feb 6 16:36:02 2008 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ABC7D16A477; Wed, 6 Feb 2008 16:36:02 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from falcon.cybervisiontech.com (falcon.cybervisiontech.com [217.20.163.9]) by mx1.freebsd.org (Postfix) with ESMTP id 4366D13C442; Wed, 6 Feb 2008 16:36:02 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from localhost (localhost [127.0.0.1]) by falcon.cybervisiontech.com (Postfix) with ESMTP id 6E34643E003; Wed, 6 Feb 2008 18:36:01 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at falcon.cybervisiontech.com Received: from falcon.cybervisiontech.com ([127.0.0.1]) by localhost (falcon.cybervisiontech.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2uP3KJXq51GZ; Wed, 6 Feb 2008 18:36:01 +0200 (EET) Received: from [10.2.1.87] (gateway.cybervisiontech.com.ua [88.81.251.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by falcon.cybervisiontech.com (Postfix) with ESMTP id 9BACA43C20E; Wed, 6 Feb 2008 18:36:00 +0200 (EET) Message-ID: <47A9E1EF.5020507@icyb.net.ua> Date: Wed, 06 Feb 2008 18:35:59 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.9 (X11/20080123) MIME-Version: 1.0 To: Scott Long References: <200612221824.kBMIOhfM049471@freefall.freebsd.org> <47A2EDB0.8000801@icyb.net.ua> <47A2F404.7010208@icyb.net.ua> <47A735A4.3060506@icyb.net.ua> <47A75B47.2040604@elischer.org> <1202155663.62432.0.camel@ikaros.oook.cz> <47A8754C.5010607@icyb.net.ua> <47A8CA83.1000405@samsco.org> In-Reply-To: <47A8CA83.1000405@samsco.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@FreeBSD.org, scottl@FreeBSD.org, freebsd-fs@FreeBSD.org, pav@FreeBSD.org, Julian Elischer , Remko Lodder Subject: Re: fs/udf: vm pages "overlap" while reading large dir [patch] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2008 16:36:02 -0000 on 05/02/2008 22:43 Scott Long said the following: > Andriy Gapon wrote: > >> But there is another issue that I also mentioned in the email about >> directory reading. It is UDF_INVALID_BMAP case of udf_bmap_internal, >> i.e. the case when file data is embedded into a file entry. >> This is a special case that needs to be handled differently. >> udf_readatoffset() handles it, but the latest udf_read code doesn't. >> I have a real UDF filesystem where this type of allocation is used for >> small files and those files can not be read. > > Oh, so directory data can also follow this convention? Blah. Feel free > to fix that too if you want =-) Yes, this allocation type can be applied to both files and directories. Directories are already handled because of readatoffset() but udf_read needs to be made aware of this special case. -- Andriy Gapon